feat: add projectId configuration, revokeDelegationForEndUser, and end user API's to TypeScript SDK by sammccord · Pull Request #624 · coinbase/cdp-sdk

sammccord · 2026-03-18T01:56:20Z

Description

Add projectId configuration and revokeDelegationForEndUser to the TypeScript SDK for delegated signing operations.

Changes

New: projectId configuration

Add projectId?: string to CdpClientOptions, reading from CDP_PROJECT_ID env var
CDPEndUserClient accepts projectId via constructor, validates at delegation call time with requireProjectId()
toEndUserAccount receives projectId through options, with its own requireProjectId() helper
All 14 delegation methods on both CDPEndUserClient and EndUserAccount now send the real project ID instead of a placeholder

New: revokeDelegationForEndUser

Expose revokeDelegationForEndUser on CDPEndUserClient (direct) and revokeDelegation on EndUserAccount
Wire through CdpOpenApiClient

Scope: TypeScript only — Python implementation deferred.

Tests

All 532 unit tests pass (pnpm test -- --run)
Lint clean (pnpm lint) aside from pre-existing no-console in cdpApiClient.ts
Updated ~25 toHaveBeenCalledWith assertions in endUser.test.ts to verify projectId is passed correctly

Checklist

Updated the typescript README if relevant
Updated the python README if relevant
Added a changelog entry
Added e2e tests if introducing new functionality

linear · 2026-03-18T01:56:24Z

CDPSDK-2350 Add revokeDelegation to cdp-sdk

cb-heimdall · 2026-03-18T01:56:25Z

✅ Heimdall Review Status

Requirement Status More Info

Reviews

✅ 2/1

Denominator calculation

Show calculation

1 if user is bot 0

1 if user is external 0

2 if repo is sensitive 0

From .codeflow.yml 1

Additional review requirements

Show calculation

Max	0

0

From CODEOWNERS 0

Global minimum 0

Max 1

1

1 if commit is unverified 0

Sum 1

github-actions · 2026-03-18T01:57:51Z

⚠️ Generated Client Files Have Been Modified

This pull request contains manual changes to generated client files. These files are automatically generated from the OpenAPI specification and should not be edited directly.

Please check the workflow logs for details on which files were modified.

To fix this issue:

Revert any manual changes to files in:
- typescript/src/openapi-client/generated/
- python/cdp/openapi_client/
- go/openapi/
- java/src/main/java/com/coinbase/cdp/openapi/
If you need to change the generated code, update the OpenAPI spec (openapi.yaml) instead
Run the generation commands locally to update the generated files

_{This comment will be automatically removed once the issue is resolved.}

sammccord · 2026-03-30T19:27:30Z

generated clients are failing because orval is trying to import the sql alpha api which does not exist in the codegen output

0xRAG · 2026-03-30T21:27:21Z

examples/typescript/end-users/signSolanaMessage.ts

+  const result = await cdp.endUser.signSolanaMessage({
+    userId: endUser.userId,
+    address: endUser.solanaAccountObjects[0].address,
+    message: Buffer.from("Hello, World!").toString("base64"),
+  });


This assumes the user has granted delegation to the developer, right? Would be good to document that in the script instructions

documented at the top

jazz-cb · 2026-03-30T22:56:38Z

typescript/src/client/end-user/endUser.test.ts

+  // ─── Delegated Sign/Send Operations ───
+
+  describe("signEvmHash", () => {
+    const mockResult = { signature: "0xsig123" };


also add a unit test for the scenario where projectID isnt set?

cb-heimdall · 2026-03-30T22:58:31Z

Review Error for sddioulde @ 2026-03-30 22:58:31 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

0xRAG · 2026-03-30T23:00:34Z

typescript/src/openapi-client/generated/end-user-accounts/end-user-accounts.ts

@@ -1,5 +1,5 @@
 /**
- * Generated by orval v7.6.0 🍺
+ * Generated by orval v7.21.0 🍺


did you want to bump orval?

according to our package.json, this is the correct version #622

0xRAG · 2026-03-30T23:01:41Z

typescript/src/openapi-client/cdpApiClient.ts

+   * Delegated routing interceptor.
+   * Registered after withAuth so it runs BEFORE the auth interceptor (LIFO order).
+   * This rewrites the URL first, then the auth interceptor computes JWT headers
+   * (Authorization and X-Wallet-Auth) against the rewritten URL path, ensuring
+   * the `uris` claim matches the actual request URL.
+   * The API gateway validates the JWT, strips the /delegated prefix, and forwards
+   * to the backend.


why is this needed? would be good to document the why

prefixed comment with explainer

…ions Verifies that all delegation operations on CDPEndUserClient throw UserInputValidationError when project ID is not configured. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

sammccord force-pushed the sammccord/cdpsdk-2350-add-revokedelegation-to-cdp-sdk branch from b413c2b to a2e7fa9 Compare March 26, 2026 19:06

sammccord changed the title ~~feat: add revokeDelegationForEndUser to TypeScript and Python SDKs~~ feat: add revokeDelegationForEndUser to TypeScript SDK Mar 27, 2026

sammccord changed the title ~~feat: add revokeDelegationForEndUser to TypeScript SDK~~ feat: add projectId configuration and revokeDelegationForEndUser to TypeScript SDK Mar 27, 2026

sammccord requested a review from 0xRAG March 27, 2026 18:01

sammccord changed the title ~~feat: add projectId configuration and revokeDelegationForEndUser to TypeScript SDK~~ feat: add projectId configuratio, revokeDelegationForEndUser, and end user API's to TypeScript SDK Mar 27, 2026

sammccord marked this pull request as ready for review March 27, 2026 21:29

sammccord changed the title ~~feat: add projectId configuratio, revokeDelegationForEndUser, and end user API's to TypeScript SDK~~ feat: add projectId configuration, revokeDelegationForEndUser, and end user API's to TypeScript SDK Mar 27, 2026

sammccord requested review from kkuhnen and sddioulde March 30, 2026 01:48

sammccord force-pushed the sammccord/cdpsdk-2350-add-revokedelegation-to-cdp-sdk branch from 01b6557 to 9730aaf Compare March 30, 2026 21:23

0xRAG reviewed Mar 30, 2026

View reviewed changes

feat(CDPSDK-2351): create/revoke delegation + endusers api, examples

9fe6cc1

sammccord force-pushed the sammccord/cdpsdk-2350-add-revokedelegation-to-cdp-sdk branch from 9730aaf to 9fe6cc1 Compare March 30, 2026 22:29

chore: add disclaimer to examples

66a75ce

sammccord requested a review from 0xRAG March 30, 2026 22:40

chore: changeset

f5e81be

jazz-cb reviewed Mar 30, 2026

View reviewed changes

sddioulde previously approved these changes Mar 30, 2026

View reviewed changes

0xRAG reviewed Mar 30, 2026

View reviewed changes

chore: add delegated routing comment

81e9e9e

sammccord dismissed sddioulde’s stale review via 81e9e9e March 30, 2026 23:11

test: add requireProjectId error tests for end user delegation operat…

e183324

…ions Verifies that all delegation operations on CDPEndUserClient throw UserInputValidationError when project ID is not configured. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

jazz-cb approved these changes Mar 30, 2026

View reviewed changes

kkuhnen approved these changes Mar 30, 2026

View reviewed changes

sammccord merged commit 0c0c1c8 into main Mar 30, 2026
49 of 51 checks passed

Conversation

sammccord commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Tests

Checklist

Uh oh!

linear bot commented Mar 18, 2026

Uh oh!

cb-heimdall commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Heimdall Review Status

Uh oh!

github-actions bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Generated Client Files Have Been Modified

Uh oh!

sammccord commented Mar 30, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cb-heimdall commented Mar 30, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants

sammccord commented Mar 18, 2026 •

edited

Loading

cb-heimdall commented Mar 18, 2026 •

edited

Loading

github-actions bot commented Mar 18, 2026 •

edited

Loading