fix: bump web3 upper bound to allow security fix GHSA-5hr4-253g-cpx2#638
Open
Kubudak90 wants to merge 2 commits intocoinbase:mainfrom
Open
fix: bump web3 upper bound to allow security fix GHSA-5hr4-253g-cpx2#638Kubudak90 wants to merge 2 commits intocoinbase:mainfrom
Kubudak90 wants to merge 2 commits intocoinbase:mainfrom
Conversation
🟡 Heimdall Review Status
|
Bumps web3 dependency from <=7.10.0 to <=7.16.0 to include the fix for CCIP Read SSRF vulnerability (GHSA-5hr4-253g-cpx2) which was patched in web3==7.15.0. Fixes coinbase#636
Kubudak90
force-pushed
the
fix-web3-security-pin
branch
from
509a775 to
c36939e
Compare
nest_asyncio is incompatible with Python 3.12+ due to its patched asyncio.run() not supporting the loop_factory parameter used by modern uvicorn. Changes: - Make nest_asyncio import and apply() optional with proper error handling - Skip nest_asyncio for Python 3.12+ to avoid breaking loop_factory support - Move nest-asyncio to optional dependencies - Update _run_async() to handle both nested and non-nested loop scenarios Fixes coinbase#591
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #636
The web3 dependency pin (
<=7.10.0) was blocking the security fix for SSRF via CCIP Read (GHSA-5hr4-253g-cpx2) which shipped inweb3==7.15.0.Changes
Updated the web3 constraint in
python/pyproject.tomlfrom:to:
This allows users to install the patched web3 version while maintaining compatibility with the existing API.
Security Impact
Testing