feat: auto add new sub account signer #1604
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephancill
force-pushed
the
feat/auto-add-new-signer
branch
from
61416e4 to
efc7b84
Compare
| ], | ||
| }; | ||
|
|
||
| const callId = (await this.sendRequestToPopup(request)) as string; |
Contributor
There was a problem hiding this comment.
this line will get blocked on mobile browser, as there are time limit on popup opening for which any async logic would break
would like to discuss if possible:
- to modernizing and standardizing the toast for opening popup after async logic, this could unblock insufficient spend permission's case
- wonder we should still move the construction of add owner call to FE, we will need to come up w a custom solution to pass signer public key to FE
stephancill
force-pushed
the
feat/auto-add-new-signer
branch
from
5d693f7 to
e835e14
Compare
Collaborator
🟡 Heimdall Review Status
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Automatically add owner to sub account if it is not registered as an owner on the sub account.
How did you test your changes?
Manually tested