-
Notifications
You must be signed in to change notification settings - Fork 725
Release 4.3.3 #1640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cb-jake
wants to merge
10
commits into
master
Choose a base branch
from
release-4.3.3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release 4.3.3 #1640
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
030612b
Add blocked popup detection with UI to retry (#1538)
arjun-dureja af7f9c1
v4.3.1
cb-jake 1dc9125
fix rpc url (#1569)
lukasrosario 767f72b
add action for canary and prod releases (#1549)
cb-jake e5431d4
mod release script
cb-jake 6867de6
update release prod script (#1571)
cb-jake 726fe00
update version
cb-jake 61f6a83
WalletLink: Move heartbeat interval to a webworker (#1638)
willnewman-cb 22ff8ac
merge
cb-jake 5cc075f
version
cb-jake File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| name: Setup | ||
| runs: | ||
| using: composite | ||
| steps: | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: '.nvmrc' | ||
| registry-url: https://registry.npmjs.org | ||
| cache: yarn | ||
|
|
||
| # For provenance https://docs.npmjs.com/generating-provenance-statements#prerequisites | ||
| - name: Install npm 9.5 | ||
| run: npm install -g npm@^9.5.0 | ||
| shell: bash | ||
|
|
||
| - name: Install node modules | ||
| run: yarn install --frozen-lockfile | ||
| shell: bash |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| name: Release (Canary) | ||
| on: | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| canary: | ||
| name: Release canary | ||
| runs-on: ubuntu-latest | ||
| environment: release | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| id-token: write | ||
| timeout-minutes: 5 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| submodules: recursive | ||
|
|
||
| - name: 'Setup' | ||
| uses: ./.github/actions/setup | ||
|
|
||
| - name: Set version | ||
| run: npm --no-git-tag-version version $(node -p "require('./packages/wallet-sdk/package.json').version")-canary.$(date +'%Y%m%d') -w packages/wallet-sdk | ||
|
|
||
| # Build the package | ||
| - name: Prebuild | ||
| run: yarn workspace @coinbase/wallet-sdk prebuild | ||
|
|
||
| - name: Build Packages | ||
| shell: bash | ||
| run: yarn build:packages | ||
|
|
||
| - name: Set deployment token | ||
| run: npm config set '//registry.npmjs.org/:_authToken' "${{ secrets.NPM_TOKEN }}" | ||
|
|
||
| - name: Publish to npm | ||
| run: cd packages/wallet-sdk && npm publish --tag canary | ||
| env: | ||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| name: Release | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| packageVersion: | ||
| description: "The version to publish in MAJOR.MINOR.PATCH format" | ||
| required: true | ||
| default: "" | ||
|
|
||
| jobs: | ||
| authorize: | ||
| name: Authorize | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: ${{ github.actor }} permission check to update release version | ||
| uses: "lannonbr/[email protected]" | ||
| with: | ||
| permission: "write" | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| release: | ||
| name: Release | ||
| runs-on: ubuntu-latest | ||
| environment: release | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| id-token: write | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| submodules: recursive | ||
|
|
||
| - name: 'Setup' | ||
| uses: ./.github/actions/setup | ||
|
|
||
| - name: Set version | ||
| run: npm version ${{ env.PACKAGE_VERSION }} -w packages/wallet-sdk | ||
|
|
||
| # Build the package | ||
| - name: Prebuild | ||
| run: yarn workspace @coinbase/wallet-sdk prebuild | ||
|
|
||
| - name: Build SDK | ||
| shell: bash | ||
| run: yarn workspace @coinbase/wallet-sdk build | ||
|
|
||
| # Create a pull request to update the version | ||
| - name: Create pull request | ||
| uses: peter-evans/create-pull-request@v4 | ||
| with: | ||
| title: "[Version update] v${{ env.PACKAGE_VERSION }}" | ||
| body: "Automated workflow: version update" | ||
| branch: release-v${{ env.PACKAGE_VERSION }} | ||
| delete-branch: true | ||
| commit-message: "v${{ env.PACKAGE_VERSION }}" | ||
| labels: version-update | ||
|
|
||
| # Publish to npm | ||
| - name: Set deployment token | ||
| run: npm config set '//registry.npmjs.org/:_authToken' "${{ secrets.NPM_TOKEN }}" | ||
|
|
||
| - name: Publish to npm | ||
| run: cd packages/wallet-sdk && npm publish --tag latest | ||
| env: | ||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| export const CB_KEYS_URL = 'https://keys.coinbase.com/connect'; | ||
| export const CB_WALLET_RPC_URL = 'http://rpc.wallet.coinbase.com'; | ||
| export const CB_WALLET_RPC_URL = 'https://rpc.wallet.coinbase.com'; | ||
| export const WALLETLINK_URL = 'https://www.walletlink.org'; | ||
| export const CBW_MOBILE_DEEPLINK_URL = 'https://go.cb-w.com/walletlink'; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Copilot Autofix
AI 8 months ago
To fix the issue, we need to add a
permissionsblock to theauthorizejob. Since the job only checks permissions and does not perform any write operations, it should be granted the minimalcontents: readpermission. This ensures that the job has only the permissions it needs to function correctly.The changes will be made in the
.github/workflows/release.ymlfile. Specifically, apermissionsblock will be added to theauthorizejob.