Adding bounds support. #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patching the ParseJSON function in L.GeoSearch.Provider.Esri to also include the bounds so that Leaflet can set the proper zoom according to geolocation accuracy. Also pinning L.GeoSearch.git to specific commit used by this repo; since `master` is now at version 2.0 which is a complete rewrite using ES6.
Adding extra `bounds` field to the IGeolocation interface. This is needed to remember the map viewport of the saved location. Partially implemented bounds in maps.js: only save and update on search. Remaining: update map bounds on view and edit.
Also updating bound values when dragging or moving the map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using this widget on an EEA project and have received a request for the map zoom to reflect the result of the geocoding accuracy. Bounds are also saved on map click, pan and zoom.
The changes required for the implementation have been:
l.geosearch.provider.esri.jsto include the contents of theextentproperty of the ArcGIS pjson response. This is already implemented in the latest version of leaflet-geosearch.boundsfield to the IGeolocation schema. Implementation in the new bounds.py.patchandcleantasks in Gruntfile.jsmasterhas advanced quite a bit.I did manual testing with and without these changes on existing and new content types. No migration step is necessary.