Add Kotlin-specific data in BSP build targets #3644
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2024
alexarchambault
force-pushed
the
kotlin-bsp-full
branch
2 times, most recently
from
785a8e1
to
09b1ed0
Compare
Just in case, I'm not sure Metals uses that. Don't know about IntelliJ.
Ideally, I'd like to pass the whole InitializeBuildParams here, but scalalib doesn't pull bsp4j (not sure if there's a reason for that)
But keep advertizing Kotlin modules as Scala ones to IntelliJ when it doesn't claim supporting Kotlin via BSP
alexarchambault
force-pushed
the
kotlin-bsp-full
branch
from
09b1ed0
to
ac8a726
Compare
|
On hold because:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Kotlin-specific data in BSP build targets of KotlinModules. This is meant to comply with how intellij-bsp seems to expect Kotlin details. If the IntelliJ version we talk to via BSP doesn't seem to support such data (that is, it doesn't claim to support Kotlin via BSP), we keep trying to have intellij-scala handle Kotlin modules, like done in #3643.