Repository navigation
feat(eks): remove dead eks_blueprints_addons; drop helm + kubectl providers (v5.0.0) - #53
Merged
Merged
Conversation
…viders (v5.0.0) module.eks_blueprints_addons deployed nothing — its only remaining feature (aws_cloudwatch_metrics) defaults false and no wrapper enables it. Delete the module block + the eks_aws_cloudwatch_metrics var (module + root + pass-through) + the now-unused local.auto_mode_controller_config, and remove the helm and gavinbunney/kubectl providers (required_providers in both versions.tf AND the provider "helm"/"kubectl" config blocks in providers.tf). Verified: the upstream terraform-aws-modules/eks (v21) needs only aws/tls/time, so nothing else pulls helm/kubectl. `terraform init`+`validate` pass; the module now requires only aws/tls/time/kubernetes/random. If Container Insights is ever needed, add aws-cloudwatch-metrics to the comet-infra umbrella instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
| default = false | ||
| } | ||
|
|
||
| variable "eks_external_dns" { |
There was a problem hiding this comment.
Stale tfvars breaks planning
The eks_aws_cloudwatch_metrics input was removed from the root module, but terraform.tfvars still sets eks_aws_cloudwatch_metrics = false, so terraform plan/apply will fail on the undeclared entry — should we delete the matching line at the same time, or keep the input until all callers are updated?
Want Baz to fix this for you? Activate Fixer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Chunk B of the k8s-free module (v5.0.0). Removes
module.eks_blueprints_addons— it deploys nothing (onlyaws_cloudwatch_metrics, which defaults false and no wrapper enables) — and drops thehelm+ third-partygavinbunney/kubectlproviders (bothrequired_providersand theproviderconfig blocks inproviders.tf).Confirmed the upstream
terraform-aws-modules/eksv21 needs only aws/tls/time, so nothing else pulls helm/kubectl.terraform init+validatepass;terraform providersnow lists only kubernetes (from the remaining kubernetes_* resources, removed in later chunks).Versioned/no cluster impact until a wrapper bumps
?ref. Container Insights, if ever needed, goes on the comet-infra umbrella instead.🤖 Generated with Claude Code
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Remove the dead
eks_blueprints_addonspath from the EKS stack and trim thecomet_eksmodule inputs so the cluster is managed only through the remaining native EKS and Kubernetes resources. Drop the unusedhelmandkubectlprovider setup from the root configuration and module constraints, leaving only the providers still needed by the surviving Kubernetes flow.eks_blueprints_addonsmodule and theeks_aws_cloudwatch_metricsinput from thecomet_eksEKS composition.Modified files (4)
Latest Contributors(2)
helmandkubectlprovider declarations and version constraints from the root and EKS module setup.Modified files (3)
Latest Contributors(2)