Skip to content

Conversation

bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Oct 4, 2025

Many nodes from this PR were tested. During conversion, minimal possible changes were made to avoid breaking such a large file.

Screenshot From 2025-10-04 19-43-50 Screenshot From 2025-10-04 19-53-31

Objects git diff:

object_info_difference.zip

@bigcat88 bigcat88 requested a review from Kosinkadink as a code owner October 4, 2025 16:54
@bigcat88
Copy link
Contributor Author

bigcat88 commented Oct 4, 2025

+label: Core

@comfy-pr-bot comfy-pr-bot added the Core Core team dependency label Oct 4, 2025
@Kosinkadink Kosinkadink changed the title [V3] convert nodes_customer_sampler.py to V3 schema [V3] convert nodes_custom_sampler.py to V3 schema Oct 4, 2025
@Kosinkadink
Copy link
Collaborator

Since this changes so many nodes + a lot of custom nodes affected at the same time, we should give 2 weeks heads up to custom nodes, and use that time for QA. We just need to make sure every node gets tested from this.

@bigcat88
Copy link
Contributor Author

bigcat88 commented Oct 5, 2025

We just need to make sure every node gets tested from this.

Should I test every node from this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Core team dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants