Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AmanSharma123456
Copy link

All Grammatical Errors removed.

Copy link
Collaborator

@gerryster gerryster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmanSharma123456 , thanks for your interest in this project. I see a couple of themes to your PR:

  1. You like the definite article (the word "the").
  2. You like the Oxford Comma. I am also a fan of the Oxford Comma as it leads to clarity in some cases. https://www.verbicidemagazine.com/2011/09/20/strippers-jfk-and-stalin-illustrate-why-you-should-use-the-serial-comma/ is a good example of this.
  3. Capitalization of proper nouns.
  4. Using a comma to separate introductory phrases such as when a sentence begins with the word such as "additionally."
  5. Preposition updates.

I am a native American English speaker, and in general I agree with your changes. I did add a note regarding two places which we do not want to change as they refer to actual JavaScript methods.


### Name

The `name` names the holiday in the local language of the selected country,
state, region. The applied language(s) can be requested using `getLanguages()`.

The language can be changed using the `setLanguages()` method. In case that not
The language can be changed using the `set languages()` method. In case that not
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be changed as it is referring to an actual method and not an English string.

translation is available a fall-back to the next given language will be made.
E.g. local language is "fr", `setLanguages('nl')` was called. For all holidays
where no dutch translation is available the French version will be used instead.
E.g. local language is "fr", `set languages('nl')` was called. For all holidays
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here...this should refer to the actual JavaScript method.

@gerryster
Copy link
Collaborator

@AmanSharma123456 : any interest in pursuing these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants