Sd 766 telefonistka get nil pointer dereference when it tries to diff a new application #27
Conversation
|
If findArgocdAppByManifestPathAnnotation reaches the end of the function it returns The log message at the end of that function is the source of the observed The foundApp is used here which, at this point in the code execution, would have returned nil. I added an additional condition to check if the found app is nil which will result in retuning the error finding the argo app error. |
jared-logan-patrick-ct
force-pushed
the
SD-766-Telefonistka-get-nil-pointer-dereference-when-it-tries-to-diff-a-new-application
branch
from
7f974f1
to
3ea2c25
Compare
jared-logan-patrick-ct
force-pushed
the
SD-766-Telefonistka-get-nil-pointer-dereference-when-it-tries-to-diff-a-new-application
branch
from
3ea2c25
to
7188f6b
Compare
internal/pkg/argocd/argocd_test.go
Outdated
| } | ||
|
|
||
| mockApplicationClient.EXPECT().List(gomock.Any(), gomock.Any()).Return(expectedResponse, nil) | ||
| app, err := findArgocdAppByManifestPathAnnotation(ctx, "right/path", "some-repo", mockApplicationClient) |
There was a problem hiding this comment.
Is the reason this doesn't return an app because right/ != right/path?
If so I would use a different string to make it extra clear
There was a problem hiding this comment.
like "Non existing app path" or something like that
Description
Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to related issues, other PRs, or technical references.
Note that by not including a description, you are asking reviewers to do extra work to understand the context of this change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.
Type of Change
Checklist