Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SD-838: fix panic #33

Merged
merged 2 commits into from
Oct 24, 2024
Merged

SD-838: fix panic #33

merged 2 commits into from
Oct 24, 2024

Commits on Oct 23, 2024

  1. Fix potential panic 

    The change [1] introduced a potential panic as it is trying to log the
app name when a failure happens, but the app variable is overridden
during such a failure and is thus nil.

This results in the following panic.

    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x20ddccb]

    goroutine 367 [running]:
    internal/pkg/argocd.generateDiffOfAComponent()
	    internal/pkg/argocd/argocd.go:477
    internal/pkg/argocd.GenerateDiffOfChangedComponents()
	    internal/pkg/argocd/argocd.go:561
    internal/pkg/githubapi.HandlePREvent()
	    internal/pkg/githubapi/github.go:161
    internal/pkg/githubapi.handleEvent()
	    internal/pkg/githubapi/github.go:382
    created by internal/pkg/githubapi.ReciveWebhook
	    internal/pkg/githubapi/github.go:322

By instead using the name from the query constructed prior, the panic
should be avoided.

[1] adbd913
    @hnnsgstfssn
    hnnsgstfssn committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    63f39c4 View commit details
    Browse the repository at this point in the history

  2. Fix lint issue 

    Linter complains about using *string for %s argument.
    @hnnsgstfssn
    hnnsgstfssn committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    03107ed View commit details
    Browse the repository at this point in the history