Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten id of WorkflowStepInput via graph_split.py #54

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

altairwei
Copy link
Contributor

I am used to using VSCode to write CWL documents and use Benten as a CWL Language Server to provide error checking for the editor. However, when I split the packed document using graph_split, I found that Benten was hinting that the id in my WorkflowStepInput was incorrect and that its id name contained an unnecessary prefix. Although I used cwltool --valid to validate the CWL document and found no problem, I wanted to correct the error that Benten was prompting, which is why I created this pull request.

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! Can you add a test case to confirm your change?

@altairwei
Copy link
Contributor Author

Thank you for this PR! Can you add a test case to confirm your change?

I can give it a try. But graph_split doesn't have enough test cases, do you feel the need to add them?

@mr-c
Copy link
Member

mr-c commented Mar 12, 2021

Thank you for this PR! Can you add a test case to confirm your change?

I can give it a try. But graph_split doesn't have enough test cases, do you feel the need to add them?

Even a single test case would be nice

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #54 (6b90034) into main (99f3b25) will increase coverage by 0.05%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   23.82%   23.87%   +0.05%     
==========================================
  Files          14       14              
  Lines       19277    19299      +22     
==========================================
+ Hits         4593     4608      +15     
- Misses      14684    14691       +7     
Impacted Files Coverage Δ
cwl_utils/graph_split.py 52.69% <81.81%> (+2.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99f3b25...6b90034. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants