-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document writing a new conformance test #124
Conversation
and better explain the format of that file and better how to invoke ./run-tests.sh
OK - I'm going to try to write the conformance test needed to close #86 following these instructions like the literal minded pedant that I am. First thing I wonder is, do I need to install |
No conda instructions for now, that package is out of date: bioconda/bioconda-recipes#30871
Yes, thanks for the reminder. I added basic instructions for installing using a virtualenv. I'll mention the conda package once bioconda/bioconda-recipes#30871 is merged and released |
We had a brief discussion about terminology: we converged on a summary that:
|
and other cleanups
What do we do about |
What are the rules for adding an Is an id even required? |
We are migrating off of
No, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now covers the questions I had in writing a test :)
Thanks @rupertnash ! I need you to review my latest clarifications again (this repo is sensitive about changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last commit further clarifies - I approve
Partial fix for common-workflow-language/cwltest#59 and common-workflow-language/cwltest#61 (some of this text should be copied over to https://github.com/common-workflow-language/cwltest/ later)
Partial fix for common-workflow-language/common-workflow-language#629
Fixes common-workflow-language/common-workflow-language#740