Fix up missing/duplicate labels and missing tags (1/n) #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
D'oh! Lets keep the duplicate and open an issue to remove it as part of CWL v1.2.1 |
mr-c
approved these changes
Nov 10, 2020
|
I added the duplicate test issue to #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings in https://github.com/common-workflow-language/cwl-v1.1/pull/72/files and starts to work on new CWL 1.2 tests.
I don't know what to do about the duplicate test below - the tests (230, 231) had different labels and tags but they were the same test. A copy-paste problem I assume? Because of the
ids, it will break the ordering to just remove it so I just appending _duplicate to the new label for the second one.I guess we don't promise the ordering of
iddoesn't have holes- should I just remove it?