Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

list regular meetings & connection information #119

Merged
merged 5 commits into from
Mar 25, 2022
Merged

list regular meetings & connection information #119

merged 5 commits into from
Mar 25, 2022

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Mar 22, 2022 •
edited by lunacodes
Loading

  • Copy down images to this repo
  • Scale image sizes to improve the layout

@netlify
Copy link

netlify bot commented Mar 22, 2022 •
edited
Loading

✅ Deploy Preview for cwl-website ready!

Name Link
🔨 Latest commit 96d4d87
🔍 Latest deploy log https://app.netlify.com/sites/cwl-website/deploys/623d1cd3c0d26500092fa4b9
😎 Deploy Preview https://deploy-preview-119--cwl-website.netlify.app/community
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mr-c mr-c requested review from lunacodes and kinow March 22, 2022 12:43
kinow
kinow approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@kinow kinow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content structure & text are perfect IMO. +1 Thanks!

content/community.md Show resolved Hide resolved
content/community.md Outdated

[EMEA](https://en.wikipedia.org/wiki/Europe,_the_Middle_East_and_Africa)-Americas: weekly [every Wednesday at 16:00 UTC from March-November and 17:00 UTC from November-March](https://arewemeetingyet.com/New%20York/2021-07-21/12:00/w/Weekly%20CWL%20Video%20Chat#eyJ1cmwiOiJodHRwczovL21lZXQuaml0LnNpL0NvbXBldGVudEJyYW5jaGVzTm9taW5hdGVXZWFrbHkifQ==)

Asia-Pacific: monthly [every first Friday of every month at 01:00 UTC](https://arewemeetingyet.com/UTC/2022-04-01/01:00/q/Monthly%20CWL%20Video%20Chat)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APAC](https://en.wikipedia.org/wiki/Asia-Pacific): ? 😬

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this in the most recent commit, but just noticed it, but just noticed it has the Outdated tag. Should I undo it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what tag was changed. I noticed that the EMEA text looks more like what's on the Google Doc, by using months. Maybe we need the same for APAC here too?

APAC CWL meetings are every first Friday of the month at 00:00 UTC April-September / 01:00 UTC October-March (invite may be updated to match the planned day)

Copy link
Contributor

@lunacodes lunacodes Mar 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kinow In the original excerpt it had:

Asia-Pacific: monthly every first Friday of every month at 01:00 UTC

I updated it Asia-Pacific to:

APAC: monthly every first Friday of every month at 01:00 UTC

Which I think is what you were requesting(?). Then I noticed the Outdated tag on this comment, and was confused.

Anyway, I'll hold off on further changes until someone else can clarify what the text should be.

@lunacodes
Copy link
Contributor

@mr-c @kinow I switched the images to be local, and reduced the image sizes (plus added a little vertical spacing). Does the sizing look alright, or should they go smaller still?

lunacodes
lunacodes approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@lunacodes lunacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, provided the image sizes are ok.

@kinow
Copy link
Member

kinow commented Mar 24, 2022

@mr-c @kinow I switched the images to be local, and reduced the image sizes (plus added a little vertical spacing). Does the sizing look alright, or should they go smaller still?

Image sizes look good to me using the GitHub UI to preview each file, @lunacodes ! Thanks!

kinow
kinow approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lunacodes I added the months to the APAC meeting (I matched when DST starts/ends here in NZ & AU, same months used in the google docs). Thanks!

@mr-c mr-c merged commit 6af7813 into main Mar 25, 2022
@mr-c mr-c deleted the weekly_meeting branch March 25, 2022 06:34
mr-c pushed a commit that referenced this pull request Mar 25, 2022
@lunacodes @mr-c
Serve Community imgs locally. Adjust img sizes & spacing - #119
7a6ee26
mr-c pushed a commit that referenced this pull request Mar 25, 2022
@lunacodes @mr-c
Change Asia-Pacific to APAC link on Community pg #119
ee02f7e
@swzCuroverse
Copy link
Contributor

Please see my note here: #126 --- we need to maintain the look and feel of the website and have a process for updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunacodes lunacodes lunacodes approved these changes

@kinow kinow kinow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mr-c @lunacodes @kinow @swzCuroverse