Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No useless dirs #1384

Merged
merged 2 commits into from
Dec 3, 2020
Merged

No useless dirs #1384

merged 2 commits into from
Dec 3, 2020

Conversation

tetron
Copy link
Member

@tetron tetron commented Dec 3, 2020

  • Fix long standing bug creating useless empty temp directories, cluttering up user's filesystem
  • Fix correctness issue getting loadListing from outputBinding.

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I was looking at something similar; this makes a lot more sense. Can we get some tests as well?

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #1384 (2e6ba5d) into main (3d026bb) will decrease coverage by 0.05%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1384      +/-   ##
==========================================
- Coverage   71.97%   71.91%   -0.06%     
==========================================
  Files          42       42              
  Lines        7767     7769       +2     
  Branches     1976     1977       +1     
==========================================
- Hits         5590     5587       -3     
- Misses       1579     1582       +3     
- Partials      598      600       +2     
Impacted Files Coverage Δ
cwltool/job.py 65.47% <0.00%> (-0.35%) ⬇️
cwltool/command_line_tool.py 64.77% <100.00%> (ø)
cwltool/process.py 82.43% <100.00%> (+0.02%) ⬆️
cwltool/executors.py 74.77% <0.00%> (-1.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d026bb...2e6ba5d. Read the comment docs.

@tetron
Copy link
Member Author

tetron commented Dec 3, 2020

The loadListing bugfix definitely needs a conformance test.

This business with creating useless output directories is a little harder to test for. Maybe it could run a workflow and then check that there are no unexpected directories left over.

@tetron
Copy link
Member Author

tetron commented Dec 3, 2020

@mergify mergify bot merged commit 70dafe0 into main Dec 3, 2020
@mergify mergify bot deleted the no-useless-dirs branch December 3, 2020 17:31
@mr-c
Copy link
Member

mr-c commented Dec 3, 2020

Oops, guess I need to tweak the mergify config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants