Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed typos in best-practices.md #315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixed typos in best-practices.md #315

wants to merge 1 commit into from

Conversation

bamiwoaluko
Copy link
Contributor

No description provided.

kinow
kinow reviewed Oct 18, 2022
View reviewed changes
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last change sounds a bit off to me. Leaving that to a native speaker to review 👍

tetron
tetron requested changes Oct 24, 2022
View reviewed changes
Copy link
Member

@tetron tetron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a typo, this was written that way an purpose. "A CWL document is code" is grammatically correct. "Dockerfiles" is plural because "components" is plural. Possibly this sentence could be rewritten to be clearer, otherwise the PR should be closed without merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinow kinow kinow left review comments

@tetron tetron tetron requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bamiwoaluko @kinow @tetron