Fix nominate for deletion

[parneet-guraya]

Fixes #6192

What changes did you make and why?

• put a condition to not fetch achievements in beta variant.
• passed callback to fragment to trigger refresh after nominate to delete call finishes.

Tests performed (required)
Tested on both beta and prod.
Device: Oneplust 9RT 5G, Android 14

Record_2025-02-18-20-14-20.1.mp4

[nicolas-raoul]

Testing this branch in prod now.
Like before, it spins forever after deletion, and the nomination is not actually sent.
Would you mind trying?

[parneet-guraya]

Strange! It does work for me. Could you try going back and opening the same media detail again? Perhaps there might be issues with refreshing? Did you see the toast message when clicking?

Record_2025-02-19-12-50-25.mp4

[nicolas-raoul]

Is your screencast in beta or prod flavor?

[parneet-guraya]

In prod

Record_2025-02-19-13-11-41.mp4

[nicolas-raoul]

Would you mind trying on a bad contribution in Explore's "Uploaded via mobile", for instance the recent upload called linkinpng?

[nicolas-raoul]

[parneet-guraya]

Would you mind trying on a bad contribution in Explore's "Uploaded via mobile", for instance the recent upload called linkinpng?

Sure!

document_6174842166125270165.mp4

[parneet-guraya]

Okay, got the bug! So, basically if you see some contributions in the list doesn't have a username showing. For some reason it isn't stored (should I create another ticket for this?). Basically, when making the request for deletion nomination userName is also passed but here nothing to pass, so request fails. That's why it never refreshes, although I should mention that the picture still get nominated eventually (if we go back and open the media page again), maybe the request that fails is part of chain and it doesn't affect the actual deletion request just that our flow of request doesn't return as expected so no refresh is triggered.

Error in the logs when username is empty so request goes out with title=User_talk%3A

document_6174842166125270324.mp4

In this case username is actually i.e User_talk%3AParryguraya appended to it.

document_6174842166125270327.mp4

I think I need to fix the other issue first then this can be merged?

[nicolas-raoul]

Other issue sounds good, thanks! :-)

[parneet-guraya]

Marking as WIP, until this merged #6209

[misaochan]

Hi @parneet-guraya , is this ready to review?

[parneet-guraya]

Hi, yes it's ready as the awaited solution was merged. Let me rebase.

[misaochan]

LGTM, happy to merge pending @nicolas-raoul 's confirmation.

[github-actions]

✅ Generated APK variants!

• 🤖 Download betaDebugAPK
• 🤖 Download prodDebugAPK

[nicolas-raoul]

Still getting the same issue 😥

screen-20250331-181306.mp4

[parneet-guraya]

Strange! are you sure you're using the correct build? for me it works for both beta and prod.

video6293965317462824229.mp4

I'm sure it worked for @misaochan too

[nicolas-raoul]

The screencast above is with this prod build: