Update fragment_media_detail.xml #6290
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Generated APK variants! |
|
Can you mark it as draft? Thank you! :-) |
|
I went ahead and changed it to draft. Please feel free to change it back when it's ready. I think for now the part where you fill the new fields with actual data is missing. |
|
Did you get a chance to continue working on this? |
|
I’ve made good progress with the changes to fragment_media_detail.xml, and I’ve worked through most of the technical setup. However, I’m currently facing an issue related to the app not properly instantiating the app component, as seen in the logcat error. This is preventing the app from running as expected, and I’m trying to resolve it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #6265
What changes did you make and why?
I worked on displaying missing metadata (author, source, and uploader) on the media detail page. These fields were not previously visible when available in the media object. The XML layout was updated to include TextViews for this information, ensuring that if the data is present, it is shown correctly to users.
Tests performed (required)
Tested ProdDebug on Pixel 6 emulator with API level 30..
Screenshots (for UI changes only)
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.