Breadcrumbs component #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-in binding functionality
Replaced selectedValue with value state variable where selectedValue is a prop assigned to the value as the state
Removed isChecked derived state and toggleRadio function
Added bind:group={value} to the radio inputs
Updated conditional visibility check to use value !== option.value
Updated aria-checked attribute to use the new value variable
…show the functionality
…onent documentaiton respectively
…mbs components works as expected
…nd dynamic title support. Intergratted logic directly in breadcrumbs component instead of using a wrapper.
…tly in the template
Ibrahim-Haizel
requested review from
ajhillman-ddj,
incontrolapps,
duncanbradley,
MikeLister and
mileshinch
Ibrahim-Haizel
changed the base branch from
add-bind-to-selected-value-radios-and-checkbox
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
Breadcrumbscomponent to the project, along with necessary integrations and examples. The component automatically generates breadcrumb navigation based on the current route and supports customisation. Key changes include the implementation of theBreadcrumbscomponent, integration into the layout, and addition of examples for usage.Implementation of Breadcrumbs Component:
src/lib/components/ui/Breadcrumbs.svelte: Added a newBreadcrumbscomponent that generates breadcrumbs based on the current route and supports customization options such as collapsing on mobile and inverse color scheme.Key implementation features
This approach is used by libraries like svelte-breadcrumbs
Integration into Layout:
src/routes/+layout.svelte: Integrated theBreadcrumbscomponent into the main layout to display breadcrumb navigation across the application to test it is working correctly. [1] [2]Addition of Examples:
src/routes/components/ui/breadcrumbs/+page.svelte: Added a new page to demonstrate the usage of theBreadcrumbscomponent with various examples and configurations.