Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Script: Synology VM #1622

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Conversation

tim104979
Copy link

✍️ Description

Tested on my own proxmox EV worked great!


  • Related Issue: #
  • Related PR: #
  • Related Discussion: #

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)

🛠️ Type of Change

Please check the relevant options:

  • [] Bug fix (non-breaking change that resolves an issue)
  • [] New feature (non-breaking change that adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

@tim104979 tim104979 requested a review from a team as a code owner January 20, 2025 20:34
@github-actions github-actions bot added new script A change that adds a new script website A change to the website labels Jan 20, 2025
@michelroegl-brunner
Copy link
Member

Files double/in wrong place.

@tim104979
Copy link
Author

This is fixed it is now only the necessary files

@MickLesk
Copy link
Member

  1. lowercase all files, workflow action blocked
  2. vm files without -install.sh, look @ debian-vm.sh
  3. ascii art is "slant" for header
  4. category in the json is wrong (0 = misc). https://community-scripts.github.io/ProxmoxVE/json-editor

@tim104979
Copy link
Author

Made the requested changes

@tim104979
Copy link
Author

made the changes

Copy link
Member

@michelroegl-brunner michelroegl-brunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok, but needs testing after merge. @MickLesk can you have a look at it befor merging? im not so familiar with the vm scripts.

@tim104979
Copy link
Author

This is fixed

@tim104979
Copy link
Author

the date was wrong in the json so i fixed that

@MickLesk
Copy link
Member

Doesnt work.

image

@tim104979
Copy link
Author

Okay i will look into what changed

@tim104979
Copy link
Author

this is now fixed

@MickLesk
Copy link
Member

nope, better test it before you tell me I can test ^^ failed again straight away.

image

@tim104979
Copy link
Author

Tested this script 4 times now

@tim104979
Copy link
Author

Can you please try again now?

@tim104979
Copy link
Author

image

@MickLesk
Copy link
Member

image

endless boot. please check before you merge. Build your Script locally and then test there.

@MickLesk MickLesk marked this pull request as draft January 28, 2025 12:51
@tim104979
Copy link
Author

just tested it with the latest change and i can fully install Synology

@tim104979 tim104979 marked this pull request as ready for review January 28, 2025 13:49
@MickLesk
Copy link
Member

Testing this is horrible. Can you write an guide? idk what i need to do with the arc loader | arc dsm module and so on. At leat about 10min testing i get it to work with http://find.synology.com and then break the assist, because he cant format the vm-hdds
image
image

@tremor021
Copy link
Member

Yea, i'm getting into loop of installing DSM 7.2 then rebooting, then back to same screen endlessly.

This need a full guide on how to test properly before it can be added to the repo

image

@michelroegl-brunner
Copy link
Member

Any progress @tim104979? Or we have to close it here.

@tim104979
Copy link
Author

Yea ofcourse this week i have exams unfortunately but I'm working on documentation for it

@MickLesk MickLesk marked this pull request as draft February 5, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new script A change that adds a new script website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants