New Script: Automatic Ripping Machine #2165
Draft
+187
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
new script
thomashondema
changed the title
MickLesk
reviewed
Feb 8, 2025
michelroegl-brunner
requested changes
Feb 10, 2025
Comment on lines
+35
to
+38
| msg_info "Updating ${APP}" | ||
| cd /opt/arm | ||
| git pull &>/dev/null | ||
| msg_ok "Updated ${APP}" |
There was a problem hiding this comment.
This needs to be reworked to not use git pull. Instead download the latest tarball.
Comment on lines
+17
to
+32
| $STD apt-get install -y \ | ||
| curl \ | ||
| sudo \ | ||
| mc \ | ||
| git \ | ||
| python3-pip \ | ||
| python3-venv \ | ||
| ffmpeg \ | ||
| libdvdcss2 \ | ||
| handbrake-cli \ | ||
| makemkv-bin \ | ||
| libavcodec-extra \ | ||
| abcde \ | ||
| flac \ | ||
| imagemagick \ | ||
| udev |
There was a problem hiding this comment.
Suggested change
| $STD apt-get install -y \ | |
| curl \ | |
| sudo \ | |
| mc \ | |
| git \ | |
| python3-pip \ | |
| python3-venv \ | |
| ffmpeg \ | |
| libdvdcss2 \ | |
| handbrake-cli \ | |
| makemkv-bin \ | |
| libavcodec-extra \ | |
| abcde \ | |
| flac \ | |
| imagemagick \ | |
| udev | |
| $STD apt-get install -y \ | |
| curl \ | |
| sudo \ | |
| mc \ | |
| git \ | |
| python3-pip \ | |
| python3-venv \ | |
| ffmpeg \ | |
| libdvdcss2 \ | |
| handbrake-cli \ | |
| makemkv-bin \ | |
| libavcodec-extra \ | |
| abcde \ | |
| flac \ | |
| imagemagick \ | |
| udev |
Comment on lines
+85
to
+86
| systemctl enable -q --now arm.service | ||
| systemctl enable -q --now armui.service |
There was a problem hiding this comment.
Suggested change
| systemctl enable -q --now arm.service | |
| systemctl enable -q --now armui.service | |
| systemctl enable -q --now arm | |
| systemctl enable -q --now armui |
Comment on lines
+14
to
+15
| var_os="ubuntu" | ||
| var_version="22.04" |
There was a problem hiding this comment.
Can you change it do debian 12, as this is our standard?
There was a problem hiding this comment.
Yes, I followed the documentation, so I used Ubuntu as recommended. However, it seems the most recent activity is aimed at Debian 12 support.
I will start from scratch based on this new information.
There was a problem hiding this comment.
Ubuntu is fine too, but maybe 24.04?
tremor021
reviewed
Feb 12, 2025
| # License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE | ||
| # Source: https://github.com/automatic-ripping-machine/automatic-ripping-machine | ||
|
|
||
| # App Default Values |
tremor021
reviewed
Feb 12, 2025
| var_version="22.04" | ||
| var_unprivileged="0" | ||
|
|
||
| # App Output & Base Settings |
tremor021
reviewed
Feb 12, 2025
| header_info "$APP" | ||
| base_settings | ||
|
|
||
| # Core |
tremor021
reviewed
Feb 12, 2025
Comment on lines
+30
to
+31
| "username": "admin", | ||
| "password": "password" |
There was a problem hiding this comment.
Can these be randomly generated or its hardcoded to admin/password?
Co-authored-by: Michel Roegl-Brunner <[email protected]>
|
./ct/automatic-ripping-machine.sh: line 2: .github/workflows/scripts/app-test/pr-build.func: No such file or directory
./ct/automatic-ripping-machine.sh: line 19: header_info: command not found ./ct/automatic-ripping-machine.sh: line 20: base_settings: command not found ./ct/automatic-ripping-machine.sh: line 23: variables: command not found ./ct/automatic-ripping-machine.sh: line 24: color: command not found ./ct/automatic-ripping-machine.sh: line 25: catch_errors: command not found ./ct/automatic-ripping-machine.sh: line 42: start: command not found ./ct/automatic-ripping-machine.sh: line 43: build_container: command not found ./ct/automatic-ripping-machine.sh: line 44: description: command not found ./ct/automatic-ripping-machine.sh: line 46: msg_ok: command not found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Description
✅ Prerequisites
The following steps must be completed for the pull request to be considered:
🛠️ Type of Change
Please check the relevant options:
📋 Additional Information (optional)
Provide any extra context or screenshots about the feature or fix here.