Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gh] Shell Format Workflow #2400

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

michelroegl-brunner
Copy link
Member

✍️ Description

This introduces a new Shell Format check to see if a few set standard lines are what we expect. If there are errors ther will be a comment with the offending Line and what should be there.

ADVISE: THIS WILL TRIGGER ON MANY SCRIPTS AT THE MOMENT
We as contributors would have to fix wrong formatted scripts either befor merge of this or when a PR with a Script comes up. This will be anyoing for a few weeks until the standards are met.

In theory we could just sed through the script and correct offending lines automaticaly, but i´m not sure if we really want that.

✅ Prerequisites

Before this PR can be reviewed, the following must be completed:

  • Self-review performed – Code follows established patterns and conventions.
  • Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

Select all that apply:

  • [] 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • [] 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • [] 🆕 New script – A fully functional and tested script or script set.

📋 Additional Information (optional)

image

@michelroegl-brunner michelroegl-brunner requested a review from a team as a code owner February 14, 2025 13:55
@michelroegl-brunner michelroegl-brunner marked this pull request as draft February 14, 2025 13:55
@github-actions github-actions bot added the maintenance Code maintenance or general upkeep of the project label Feb 14, 2025
@michelroegl-brunner
Copy link
Member Author

Any look at the code and changes to the checks are welcome, either check out the PR Repo do do it in your editor or in GH Web (File->Edit). Changes will be commited to the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code maintenance or general upkeep of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant