Add missing mount_options parameter in filesystem #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes community-terraform-providers#79 There was some mixup between the "mount" option from Ignition v2 and the "options" and "mountOptions" from Ignition v3.1+ This commit fixes the names of the related functions, adds mountOptions support and updates the documentation accordingly. Signed-off-by: Florian Maury <[email protected]>
yussufsh
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79
There was some mixup between the "mount" option from Ignition v2 and the "options" and "mountOptions" from Ignition v3.1+
This commit fixes the names of the related functions, adds mountOptions support and updates the documentation accordingly.
This is my very first PR on a terraform provider, so there might be some mistakes or oversights. Please do not hesitate to tell me how to improve it :)