Better Python Practices and Delphi Improvements #2204
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ballPointPenguin
force-pushed
the
br/python-better
branch
2 times, most recently
from
d369e6e to
33cd326
Compare
tevko
reviewed
Oct 17, 2025
| "Delphi_PCAConversationConfig": { | ||
| "KeySchema": [{"AttributeName": "zid", "KeyType": "HASH"}], | ||
| "AttributeDefinitions": [{"AttributeName": "zid", "AttributeType": "S"}], | ||
| "ProvisionedThroughput": {"ReadCapacityUnits": 5, "WriteCapacityUnits": 5}, |
Collaborator
There was a problem hiding this comment.
There should be NO provisioned throughput on any table we use or create, all tables should rely on "on-demand" capacity, aka "BillingMode": "PAY_PER_REQUEST",
tevko
reviewed
Oct 17, 2025
| [ ] Audit and fix pytest tests | ||
| [ ] Establish delphi tests github workflow | ||
| [x] Refactor make docker commands to use docker directly without docker compose | ||
| [ ] Confirm or remove `configure_instance.py` |
Collaborator
There was a problem hiding this comment.
some of these are used in prod application setup process during code deploy phase in AWS
tevko
reviewed
Oct 17, 2025
| # SENTENCE_TRANSFORMER_MODEL=sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2 | ||
|
|
||
| # Database configuration | ||
| DATABASE_HOST=localhost |
Collaborator
There was a problem hiding this comment.
ideally we don't have this at all / all env config is handled at project root level
tevko
reviewed
Oct 17, 2025
| @@ -119,13 +119,13 @@ services: | |||
| image: 050917022930.dkr.ecr.us-east-1.amazonaws.com/polis/delphi:latest | |||
| build: | |||
| context: ./delphi | |||
| container_name: delphi-app | |||
Collaborator
There was a problem hiding this comment.
need to make sure this doesn't conflict with prod setup in AWS
ballPointPenguin
force-pushed
the
br/python-better
branch
from
33cd326 to
cf3265d
Compare
ballPointPenguin
force-pushed
the
br/python-better
branch
from
cf3265d to
43c0ace
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.