Add variadic support for templates #324
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
=======================================
Coverage 75.94% 75.94%
=======================================
Files 9 9
Lines 3646 3646
=======================================
Hits 2769 2769
Misses 877 877 🚀 New features to boost your workflow:
|
aaronj0
force-pushed
the
variadic-support
branch
from
e87e146 to
9412530
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
aaronj0
force-pushed
the
variadic-support
branch
from
9412530 to
2ef2734
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
There is an added unittest... It is still a draft though, will update with a case for |
aaronj0
force-pushed
the
variadic-support
branch
from
2ef2734 to
3603d06
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
| TEST(FunctionReflectionTest, InstantiateVariadicFunctionTemplate) { | ||
| std::vector<Decl*> Decls; | ||
| std::string code = R"( | ||
| template<typename... Args> void VariadicFnTemplate(Args... args) {} |
There was a problem hiding this comment.
Can we include the example of #305?
There was a problem hiding this comment.
The current test mimics the same variadic template, I am extending it to initialize using a template pack which should cover the other branch for codecov
There was a problem hiding this comment.
Still worth adding the test from the issue and adding code to support it.
aaronj0
force-pushed
the
variadic-support
branch
from
3603d06 to
ad55091
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
This PR is stale because it has been open for 90 days with no activity. |
aaronj0
force-pushed
the
variadic-support
branch
from
ad55091 to
6155f34
Compare
|
@aaronj0 to get past the undefined symbols error with the Emscripten jobs, add the symbols in this file https://github.com/aaronj0/CppInterOp/blob/variadic-support/lib/Interpreter/exports.ld , following the pattern already in the file. Eventually we will work out why these symbols are not being exported, fix it, and remove the file, but for now this is what we are doing when a new llvm or clang symbols is not being exported. |
No description provided.