Skip to content

Initialize default PrintingPolicy in CreateInterpreter #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joyy-7921 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Initialize default PrintingPolicy in CreateInterpreter #841

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42fc34d
Initialize default PrintingPolicy in CreateInterpreter and reuse ASTC…
joyy-7921 Mar 6, 2026
446c49a
Adjust PrintingPolicy handling after CI failures
joyy-7921 Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions lib/CppInterOp/CppInterOp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1141,6 +1141,9 @@ std::string GetFunctionSignature(TCppFunction_t func) {
std::string Signature;
raw_string_ostream SS(Signature);
PrintingPolicy Policy = getASTContext().getPrintingPolicy();
Policy.SuppressUnwrittenScope = false;
Policy.AnonymousTagLocations = true;
Policy.SuppressTemplateArgsInCXXConstructors = true;
// Skip printing the body
Policy.TerseOutput = true;
Policy.FullyQualifiedName = true;
Expand Down Expand Up @@ -1822,9 +1825,10 @@ TCppType_t GetUnderlyingType(TCppType_t type) {
std::string GetTypeAsString(TCppType_t var) {
QualType QT = QualType::getFromOpaquePtr(var);
// FIXME: Get the default printing policy from the ASTContext.
PrintingPolicy Policy((LangOptions()));
Policy.Bool = true; // Print bool instead of _Bool.
Policy.SuppressTagKeyword = true; // Do not print `class std::string`.
PrintingPolicy Policy = getASTContext().getPrintingPolicy();
Policy.SuppressUnwrittenScope = false;
Policy.AnonymousTagLocations = true;
Policy.SuppressTemplateArgsInCXXConstructors = true;
Policy.SuppressElaboration = true;
Policy.FullyQualifiedName = true;
return QT.getAsString(Policy);
Expand Down Expand Up @@ -2035,9 +2039,8 @@ static void GetDeclName(const clang::Decl* D, ASTContext& Context,
std::string& name) {
// Helper to extract a fully qualified name from a Decl
PrintingPolicy Policy(Context.getPrintingPolicy());
Policy.SuppressTagKeyword = true;
Policy.SuppressUnwrittenScope = true;
Policy.Print_Canonical_Types = true;

if (const TypeDecl* TD = dyn_cast<TypeDecl>(D)) {
// This is a class, struct, or union member.
QualType QT;
Expand All @@ -2054,7 +2057,6 @@ static void GetDeclName(const clang::Decl* D, ASTContext& Context,
stream.flush();
}
}

void collect_type_info(const FunctionDecl* FD, QualType& QT,
std::ostringstream& typedefbuf,
std::ostringstream& callbuf, std::string& type_name,
Expand Down Expand Up @@ -3427,6 +3429,16 @@ TInterp_t CreateInterpreter(const std::vector<const char*>& Args /*={}*/,
)");

sInterpreters->emplace_back(I, /*Owned=*/true);
clang::ASTContext& C = I->getCI()->getASTContext();
clang::PrintingPolicy Policy = C.getPrintingPolicy();

Policy.Bool = true;
Policy.SuppressTagKeyword = true;
Policy.SuppressUnwrittenScope = true;
Policy.AnonymousTagLocations = false;
Policy.SuppressTemplateArgsInCXXConstructors = false;

C.setPrintingPolicy(Policy);

// Define runtime symbols in the JIT dylib for clang-repl
#if !defined(CPPINTEROP_USE_CLING) && !defined(EMSCRIPTEN)
Expand Down
Loading