Skip to content

The "lookup" should be silent. #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vgvassilev wants to merge 3 commits into
base: master
Choose a base branch
from
Open

The "lookup" should be silent. #192

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e043999
The "lookup" should be silent.
vgvassilev Mar 30, 2026
c36c0e6
sanity
vgvassilev Apr 1, 2026
d750696
Update clingwrapper.cxx
vgvassilev Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions clingwrapper/src/clingwrapper.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,8 +677,7 @@ bool Cppyy::AppendTypesSlow(const std::string& name,
Cpp::Declare(code.c_str(), /*silent=*/true); // initialize the trampoline

std::string var = "__Cppyy_s" + std::to_string(struct_count++);
// FIXME: We cannot use silent because it erases our error code from Declare!
if (!Cpp::Declare(("__Cppyy_AppendTypesSlow<" + resolved_name + "> " + var +";\n").c_str(), /*silent=*/false)) {
if (!Cpp::Declare(("__Cppyy_AppendTypesSlow<" + resolved_name + "> " + var +";\n").c_str(), /*silent=*/true)) {
std::lock_guard<std::recursive_mutex> Lock(InterOpMutex);
TCppType_t varN =
Cpp::GetVariableType(Cpp::GetNamed(var.c_str(), /*parent=*/nullptr));
Expand Down
Loading