Skip to content

Conversation

mcbarton
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

This PR is part of a series of PRs to improve the testing of xeus-cpp kernels. The purpose of this first PR is to run the python kernel tests for all c++ kernels and not just a single kernel (currently xcpp20).

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.78%. Comparing base (27a9f21) to head (0a76d4b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #384   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files          20       20           
  Lines         950      950           
  Branches       87       87           
=======================================
  Hits          777      777           
  Misses        173      173           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcbarton
Copy link
Collaborator Author

mcbarton commented Sep 30, 2025

This PR can almost certainly be done in fewer lines. Python is not my strong suit, and I've just done it in a way which was clear to me.

@mcbarton mcbarton force-pushed the Run-kernel-tests-for-all-c++-kernels branch from 140f1d2 to 0a76d4b Compare October 1, 2025 21:46
@mcbarton
Copy link
Collaborator Author

mcbarton commented Oct 6, 2025

@JohanMabille pinging for review

The purpose of this PR is to make it so that all the c++ kernels are tested. Currently only 1 is tested. In future PRs I plan to expand this to test the new c kernels too. With xeus-cpp about to get debug kernels too, its useful that it has a mechanism to run test sets for multiple kernels.

@JohanMabille
Copy link
Collaborator

Awesome! Testing all the available kernels is something I should have done earlier, thanks for fixing it!

@mcbarton mcbarton merged commit 51c3cb2 into compiler-research:main Oct 9, 2025
26 of 27 checks passed
@mcbarton mcbarton deleted the Run-kernel-tests-for-all-c++-kernels branch October 9, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants