build: repair the bazel build on Darwin #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This repairs the Darwin ARM64 build of ds2 via bazel which was broken due to a missing case for the defines and a typo in the dependency.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Bazel build on Darwin ARM64 by correcting a typo in a build target reference and adding a missing default case to platform-specific defines.
Key Changes:
- Fixed typo in ARM register definitions header target name
- Added default case for conditional defines to handle Darwin platforms
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repairs the Darwin ARM64 build of ds2 via bazel which was broken due to a missing case for the defines and a typo in the dependency.