actions: Add a configure-cmake-project action #999
+580
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@compnerd I noticed we have a few differences in flags:
Should we unify these? And if so, which way should we go? |
Steelskin
changed the title
Yes, we should! For the Android side, actually the GHA is the ideal form. For the Windows side, the build.ps1 side is better IMO. |
compnerd
reviewed
Jul 31, 2025
Comment on lines
25
to
28
| os: | ||
| description: Operating system to build for (e.g., "Windows", "Android"). | ||
| required: true | ||
| arch: |
There was a problem hiding this comment.
Can we name these host-os and host-arch?
There was a problem hiding this comment.
I do not think they should, as they can be either build, host or target depending on the job.
Steelskin
force-pushed
the
fabrice/call-cmake-action
branch
4 times, most recently
from
ca52164 to
90104d5
Compare
Steelskin
changed the title
This brings in a modified version of `build.ps1` from the swift repository as a custom action. This reduces the differences in the build setup between the swift repository and this repository, making it easier to keep both builds in sync.
Steelskin
force-pushed
the
fabrice/call-cmake-action
branch
from
90104d5 to
3a1c55b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in a modified version of
Build-CMakeProjectinbuild.ps1from the swift repository as a custom action. This reduces the differences in the build setup between the swift repository and this repository, making it easier to keep both builds in sync.The new reusable action only configures the CMake project in order to keep the build and install steps as separate steps in the GitHub Actions UI.