Skip to content

Dont interpolate removed text nodes #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Dont interpolate removed text nodes #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe960bc
Dont process removed nodes
Sep 4, 2014
2dfe287
dont interpolate removed text nodes
Sep 4, 2014
a70d217
Add test for data-html replacing text
Sep 4, 2014
711e28e
Make tests IE9 compatible (type=email doesnt work, so use set/getAttr…
Sep 4, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ Reactive.prototype._bind = function() {
return next(skip);
}
// text
else if (el.nodeType == 3) {
else if (el.nodeType == 3 && el.parentNode) {
if (utils.hasInterpolation(el.data)) {
debug('bind text "%s"', el.data);
new TextBinding(self, el);
Expand Down
8 changes: 8 additions & 0 deletions test/bindings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,3 +103,11 @@ describe('Reactive#bind(name, fn)', function(){
assert(el.value == 'value');
})
})

describe('data-html', function () {
it('should replace html content', function(){
var el = domify('<div data-html="value">text to be replaced</div>');
var view = reactive(el, { value: '<div data-html="value"></div>' });
assert(el.innerHTML === '<div data-html="value"></div>');
})
})
6 changes: 3 additions & 3 deletions test/reactive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,15 +313,15 @@ describe('data-replace', function(){
var input = document.createElement('input');
var el = domify('<div><div type="email" data-replace="input"></div>');
var view = reactive(el, {}, { delegate: { input: input } });
assert('email' == input.type);
assert('email' == input.getAttribute('type'));
})

it('shouldnt wipe out existing attributes', function(){
var input = document.createElement('input');
input.type = 'url'
input.setAttribute('type', 'url')
var el = domify('<div><div type="email" data-replace="input"></div>');
var view = reactive(el, {}, { delegate: { input: input } });
assert('url' == input.type);
assert('url' == input.getAttribute('type'));
})

it('should carryover classes', function(){
Expand Down