Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for libgdal310 #302

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update libgdal310.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11905195130 - please use this URL for debugging.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@seisman
Copy link
Contributor

seisman commented Nov 20, 2024

@joa-quim We need your help here.

This PR is trying to rebuild GMT 6.5.0. As you can see, the build fails on Windows (Windows Server 2022, OS Version: 10.0.20348 Build 2849). The detailed CI report is available at https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1085662&view=logs&j=fe7faf59-69bb-5487-b8fd-a35a7bda3a51&t=7c4a7e41-4b0a-44cb-8cac-ff48287f393d&l=5.

The main error messages are:

gmtlogo.c
%SRC_DIR%\src\gmtlogo.c(38): error C2099: initializer is not a constant
%SRC_DIR%\src\gmtlogo.c(131): error C2099: initializer is not a constant
%SRC_DIR%\src\gmtlogo.c(145): error C2099: initializer is not a constant

Looking at the GMT gmtlogo.c, it seems line 38, 131, 145 contain NAN, so it's likely for some unknown reasons, the symbol NAN is not defined or is not a valid constant on this new Windows version or MSVC.

@seisman
Copy link
Contributor

seisman commented Nov 20, 2024

Actually we can see the same errors in the latest builds in the GMT repository (https://github.com/GenericMappingTools/gmt/actions/runs/11927165683/job/33242134547?pr=8626), because the CI Windows agent has upgraded from 10.0.20348 Build 2762 to 10.0.20348 Build 2849 a few hours before.

@joa-quim
Copy link

That is so strange. I found the NAN definition in my
C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\ucrt\corecrt_math.h
Could it have moved into another header? Because pure disappearing makes no sense. Anyway, lets see if the #8627 solves this.

@seisman
Copy link
Contributor

seisman commented Nov 22, 2024

@conda-forge-admin, please rerender

@seisman seisman merged commit 6021812 into conda-forge:main Nov 22, 2024
9 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-libgdal310-0-1_h36ccca branch November 22, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants