Skip to content

Rebuild for flang 21#10

Open
regro-cf-autotick-bot wants to merge 2 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:rebuild-flang21-0-1_h715106
Open

Rebuild for flang 21#10
regro-cf-autotick-bot wants to merge 2 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:rebuild-flang21-0-1_h715106

Conversation

@regro-cf-autotick-bot

Copy link
Copy Markdown
Contributor

This PR has been triggered in an effort to update flang21.

IMPORTANT: If you close this PR, the bot will presume that the feedstock has been rebuilt with this update and WILL NOT MAKE ANOTHER PR. Please follow the instructions below for handling this PR.

Notes and instructions for handling this PR:

  • If your package IS COMPATIBLE with this update and...
    • the tests have passed, please merge this PR!
    • the tests have not passed, please make changes and/or rerun the tests so that they pass. Feel free to push to the bot's branch to update this PR if needed. Then merge the PR once the tests pass!
    • you find it easier to do the update in another PR, please do not close this PR until the other PR is merged.
  • If your package IS NOT YET COMPATIBLE with this update, please leave this PR open. The bot will detect conflicts and remake the PR as new versions are pushed. Once the package is at a compatible version, please merge the update PR for that version.
  • If your package WILL NEVER BE COMPATIBLE with this update, please convert this PR to draft.
  • If this PR HAS CONFLICTS and...
    • you do NOT want to resolve them yourself, add a bot-rerun label and the bot will do it for you. See the instructions below if you do not have permissions to add a label.
    • you do want to resolve them yourself, by all means go ahead (either in the UI or via the git CLI)!

Here are some more details about this specific migrator:

TL;DR: We are trying to switch our Fortran compilers on windows to flang.
This is not 100% guaranteed to work, but should be fine in the majority of cases.

The new LLVM-based flang has become mature enough that it should be possible to
broadly switch over our Fortran compilers on windows to it (until now we only had
an ancient pre-LLVM flang 5, or alternatively the GCC-based m2w64_fortran).

As such, this PR attempts to homogenize any use of m2w64_fortran and other m2w64_*
compilers to our default stack (which would then be MSVC + flang on windows), with
the exception of feedstocks for R-packages, which stay on the m2w64_ compilers.

Recipes that have hard-coded expectations about the name of the fortran compiler
will need to adjust to use %FC% or flang for the compiler name. Similarly,
you may need to change the linker to %FC_LD% or use lld-link.

It is also possible that you run into compilation errors due to differences in
compiler behaviour, bugs or as-yet unimplemented features. In case of compilation
errors due to stricter default language standards, you should be able to fix things
by passing -std=legacy to FFLAGS.

If you have problems with this PR, feel free to ping the @c-f/flang-activation team.
In case you have convinced yourself that flang really is not ready yet to be used to
compile a given feedstock, you may also close this migrator PR.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the conda-forge-bot. The conda-forge-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/conda-forge/conda-forge-bot/actions/runs/26954256374 - please use this URL for debugging.

TL;DR: We are trying to switch our Fortran compilers on windows to flang.
This is not 100% guaranteed to work, but should be fine in the majority of cases.

The new LLVM-based flang has become mature enough that it should be possible to
broadly switch over our Fortran compilers on windows to it (until now we only had
an ancient pre-LLVM flang 5, or alternatively the GCC-based `m2w64_fortran`).

As such, this PR attempts to homogenize any use of `m2w64_fortran` and other `m2w64_*`
compilers to our default stack (which would then be MSVC + flang on windows), with
the exception of feedstocks for R-packages, which stay on the `m2w64_` compilers.

Recipes that have hard-coded expectations about the name of the fortran compiler
will need to adjust to use `%FC%` or `flang` for the compiler name. Similarly,
you may need to change the linker to `%FC_LD%` or use `lld-link`.

It is also possible that you run into compilation errors due to differences in
compiler behaviour, bugs or as-yet unimplemented features. In case of compilation
errors due to stricter default language standards, you should be able to fix things
by passing `-std=legacy` to `FFLAGS`.

If you have problems with this PR, feel free to ping the @c-f/flang-activation team.
In case you have convinced yourself that flang really is not ready yet to be used to
compile a given feedstock, you may also close this migrator PR.
@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@RobertPincus

Copy link
Copy Markdown
Contributor

@c-f/flang-activation The Windows/CMake/Ninja build is failing with linker errors - symbols are not found that certainly do exist within the source tree. Any advice on how to debug?

@RobertPincus

Copy link
Copy Markdown
Contributor

@conda-forge/flang-activation The Windows/CMake/Ninja build is failing with linker errors - symbols are not found that certainly do exist within the source tree. Any advice on how to debug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants