Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 - Add sdl2 recipe in the v2 branch of sdl-feedstock while maintaining the history of sdl2-feedstock #15

Merged
merged 106 commits into from
Feb 14, 2025
Merged

v2 - Add sdl2 recipe in the v2 branch of sdl-feedstock while maintaining the history of sdl2-feedstock #15

merged 106 commits into from
Feb 14, 2025

Conversation

ymontmarin
Copy link
Contributor

@ymontmarin ymontmarin commented Feb 13, 2025 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Yann de Mont-Marin and others added 30 commits February 13, 2025 11:50
Clean for incomming history of sdl2-feedstock
b92a431
Initial commit of the sdl2 feedstock.
2c4d7c8
Re-render the feedstock after CI registration.
a15dbc0
@dschreij
Add Python as build dep for feature activation
a189e21
@dschreij
Add comment with feature activation (conda-forge#1)
95944b2 
* Add comment with feature activation

* Try to force builds other than Py27+vc9

* Fix meta.yaml again to force other vc builds

* Update appveyor matrix settings

* MNT: Re-rendered with conda-smithy 1.5.3
@dschreij
Updated build number to 1 (conda-forge#2)
f93e615
[ci skip] [skip ci] Update anaconda token
3fe3340
@dschreij
MNT: Re-rendered with conda-smithy 2.4.5 (conda-forge#5)
8b5c87b
@dschreij
Update SDL2 to 2.0.7
9e0172f
@matham
Enable building with x on linux (conda-forge#7)
0ca56e1 
* Add xorg to build

* Build with x on linux.

* Flipped mac vs linux check.

* Fix spacing for linter.
@matham
Update SDL2 to 2.0.8. (conda-forge#8)
60efe47
[ci skip] [skip ci] Update anaconda token
3f37801
bump build number
ae294ff
bump build number
5b04d12
MNT: Re-rendered with conda-smithy 3.1.12 and pinning 2018.11.27
d4f516d
@ocefpaf
update-cb3
d4f53a9
@ocefpaf
MNT: Re-rendered with conda-smithy 3.1.12 and pinning 2018.11.27
66ef546
@jakirkham
Strip trailing whitespace
ae7ed70
@jakirkham
Drop hard-coded path to cmake
6ef3de5 
As conda-build will ensure `cmake` is on the path and this path is now
wrong, drop the path to `cmake` and just call the executable and trust
the right one will be found.
@dschreij
Add libxext as linux dep
e9d4768
@dschreij
Add vc dependencies to run section
2ddc5df
@dschreij
Remove vc features again
7a73ea9
@grlee77
add patch to link vcruntime on MSVC2015
47f2f1c
@grlee77
MNT: Re-rendered with conda-smithy 3.2.2 and pinning 2018.12.28
4ed2875
@grlee77
fix MSVC_VERSION number in msvc2015.patch
28b20bd
@matham
Increase the sdl2 version (conda-forge#12)
2841a03 
* Try increasing the sdl2 version.

* Reset build number.

* MNT: Re-rendered with conda-build 3.17.8, conda-smithy 3.3.3, and conda-forge-pinning 2019.04.18

* Detect vs2008 based on compiler, not py version.

* Disable joystick for 2008.

* Turn ON HIDAPI.

* Use proper flag to disable joystick

* osx seems to need to link to ForceFeedback

Otherwise we get

```
Undefined symbols for architecture x86_64:
  "_FFCreateDevice", referenced from:
      _DARWIN_JoystickRumble in SDL_sysjoystick.o
```

* Disable haptic for 2008 as well.

* Is it being called?

* Properly set ldflags.

* Quote problems.

* Re-enable joystic as it didn't fix anything

* Does a non-empty array fix it?

* Add msvc9 patch to handle empty array.

* Apply patch.

* Don't use dummy.

* Select only 2008. vc seems to always be 14!?
@matham
Add the required packages to link to libgl (conda-forge#14)
b375967 
* Add the required packages to link to libgl

Possibly fixes conda-forge/sdl2-feedstock#13.

* Bump build number
@matham
x11 is needed on the build environment to build with x11 support (con…
c289fbd 
…da-forge#15)

* x11 is needed on the build environment to build with x11 support

* Added myself and bump build.

* Show config log

* Find xlib.h

* Update build.sh

* Add libx11-devel

* Update meta.yaml

* Try proto-devel

* Cleanup
@regro-cf-autotick-bot
sdl2 v2.0.10 (#16)
6ed317b 
* updated v2.0.10

* MNT: Re-rendered with conda-build 3.18.9, conda-smithy 3.4.1, and conda-forge-pinning 2019.07.23
@conda-forge-admin
[ci skip] ***NO_CI*** Move from appveyor to azure.
2354c4a 
See conda-forge/conda-forge.github.io#857
@ymontmarin
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@ymontmarin ymontmarin changed the title Add sdl V2 with history for sdl2 being in this feedstock Add sdl2 recipe in the v2 branch of sdl-feedstock while maintaining the history of sdl2-feedstock Feb 13, 2025
@ymontmarin
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13307160262. Examine the logs at this URL for more detail.

@ymontmarin ymontmarin changed the title Add sdl2 recipe in the v2 branch of sdl-feedstock while maintaining the history of sdl2-feedstock v2 - Add sdl2 recipe in the v2 branch of sdl-feedstock while maintaining the history of sdl2-feedstock Feb 13, 2025
@ymontmarin ymontmarin mentioned this pull request Feb 13, 2025
Open
10 tasks
@ymontmarin
Copy link
Contributor Author

To merge after output validation via token --> see discussion in conda-forge/staged-recipes#29061

@ymontmarin
Copy link
Contributor Author

@conda-forge-admin, please rerender

@ymontmarin
Copy link
Contributor Author

@traversaro Is this one ok ?
It is exactly the one from the feedstock but using package instead of cdts.

@ymontmarin ymontmarin merged commit 0180bfd into conda-forge:v2 Feb 14, 2025
9 checks passed
@traversaro
Copy link
Contributor

@traversaro Is this one ok ? It is exactly the one from the feedstock but using package instead of cdts.

Please wait for a feedback from other maintainers before merging, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobias-Fischer Tobias-Fischer Awaiting requested review from Tobias-Fischer

@seanyen seanyen Awaiting requested review from seanyen

@traversaro traversaro Awaiting requested review from traversaro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.