Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main - Update the main branch for sdl3 recipe #17

Merged
merged 20 commits into from
Feb 14, 2025

Conversation

ymontmarin
Copy link
Contributor

@ymontmarin ymontmarin commented Feb 13, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@ymontmarin
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@ymontmarin ymontmarin changed the title main - Update the recipe folder to deliver sdl3 package main - Update the main branch for sdl3 recipe Feb 13, 2025
@ymontmarin
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13309355327. Examine the logs at this URL for more detail.

@ymontmarin
Copy link
Contributor Author

To merge after output validation via token --> see discussion in conda-forge/staged-recipes#29061

@traversaro
Copy link
Contributor

@ManifoldFR @matham @dschreij can you confirm you are ok in being added as maintainers here?

@ManifoldFR
Copy link

Yes, I confirm I agree to be a maintainer

@ymontmarin
Copy link
Contributor Author

@ManifoldFR @matham @dschreij can you confirm you are ok in being added as maintainers here?

From what @h-vetinari said in conda-forge/sdl2-feedstock#60, @dschreij looks inactive on github, but I put them as maintainer as they were on sdl2-feedstock and I did pull the history from there. But If we are enough maintainers, I can remove them.

@traversaro
Copy link
Contributor

@ManifoldFR @matham @dschreij can you confirm you are ok in being added as maintainers here?

From what @h-vetinari said in conda-forge/sdl2-feedstock#60, @dschreij looks inactive on github, but I put them as maintainer as they were on sdl2-feedstock and I did pull the history from there. But If we are enough maintainers, I can remove them.

I would just add active maintainers that actively specified they want to be maintainer. If a former mantainer of sdl2 wants to be added here, he/she just need to ask.

@ymontmarin
Copy link
Contributor Author

@conda-forge-admin, please rerender

@ymontmarin
Copy link
Contributor Author

@traversaro is it ok for you if I merge ? (this one and the v2 one)

recipe/build.sh Outdated Show resolved Hide resolved
@ymontmarin
Copy link
Contributor Author

@conda-forge-admin, please rerender

recipe/build.sh Outdated Show resolved Hide resolved
@traversaro traversaro added the automerge Merge the PR when CI passes label Feb 14, 2025
@traversaro
Copy link
Contributor

CI on linux-aarch64 aand linux-ppc64le is taking forever, can't we use cross-compilation there?

@traversaro
Copy link
Contributor

@conda-forge-admin please rerender

@conda-forge-curator conda-forge-curator bot removed the automerge Merge the PR when CI passes label Feb 14, 2025
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@ymontmarin
Copy link
Contributor Author

Thank you for the cross-compilation.
Should we add the abi branches v2 and v1.2 for the bot in conda_forge.yml in this PR or in a following one ?
Sorry for the too early merge of the v2 branch.

@traversaro
Copy link
Contributor

Should we add the abi branches v2 and v1.2 for the bot in conda_forge.yml in this PR or in a following one ?

Let's add them here, thanks!

Sorry for the too early merge of the v2 branch.

No problem!

@ymontmarin
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13332845445. Examine the logs at this URL for more detail.

@traversaro traversaro merged commit 1a7adf3 into conda-forge:main Feb 14, 2025
10 checks passed
@traversaro
Copy link
Contributor

Thanks @ymontmarin !

@ymontmarin
Copy link
Contributor Author

Thanks for the merge @traversaro !

It looks like the CI is not launching when merge in the conda-forge/feedstock ?

@traversaro
Copy link
Contributor

It looks like the CI is not launching when merge in the conda-forge/feedstock ?

I triggered a build in 0c88c68 .

@ymontmarin
Copy link
Contributor Author

Thank you !
Could you do the same for the v2 branch ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants