Skip to content

Add asciidoctor-reducer#27843

Merged
ocefpaf merged 7 commits intoconda-forge:mainfrom
ajaypnair09:Add-asciidoctor-reducer
Feb 12, 2025
Merged

Add asciidoctor-reducer#27843
ocefpaf merged 7 commits intoconda-forge:mainfrom
ajaypnair09:Add-asciidoctor-reducer

Conversation

@ajaypnair09
Copy link
Contributor

@ajaypnair09 ajaypnair09 commented Oct 11, 2024 •
edited
Loading

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024

Hi! This is the staged-recipes linter and I found some lint.

It looks like some changes were made outside the recipes/ directory. To ensure everything runs smoothly, please make sure that recipes are only added to the recipes/ directory and no other files are changed.

If these changes are intentional (and you aren't submitting a recipe), please add a maintenance label to the PR.

File-specific lints and/or hints:

  • LICENSE:
    • lints:
      • Do not edit files outside of the recipes/ directory.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 11, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/asciidoctor-reducer/meta.yaml) and found it was in an excellent condition.

@ajaypnair09 ajaypnair09 force-pushed the Add-asciidoctor-reducer branch from 73cf6ef to 5617f27 Compare October 11, 2024 06:03
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@ajaypnair09 ajaypnair09 force-pushed the Add-asciidoctor-reducer branch 16 times, most recently from 865107d to cb33673 Compare October 11, 2024 11:23
@ajaypnair09 ajaypnair09 force-pushed the Add-asciidoctor-reducer branch from cb33673 to a986c34 Compare October 11, 2024 11:30
@ajaypnair09
Copy link
Contributor Author

ajaypnair09 commented Oct 11, 2024

@conda-forge/ruby Please review and merge if everything looks fine

@ajaypnair09 ajaypnair09 force-pushed the Add-asciidoctor-reducer branch from c0ec640 to 95c0db0 Compare October 14, 2024 09:13
@ajaypnair09 ajaypnair09 force-pushed the Add-asciidoctor-reducer branch from 95c0db0 to 4f41c5f Compare October 14, 2024 09:23
@ajaypnair09 ajaypnair09 marked this pull request as draft October 14, 2024 09:44
@ajaypnair09
Copy link
Contributor Author

ajaypnair09 commented Oct 14, 2024

Waiting for asciidoctor-feedstock/pull/16

@ajaypnair09 ajaypnair09 force-pushed the Add-asciidoctor-reducer branch from dd408c5 to aba37fe Compare October 14, 2024 13:28
@ajaypnair09 ajaypnair09 marked this pull request as ready for review October 15, 2024 12:05
@ajaypnair09 ajaypnair09 requested a review from wolfv October 15, 2024 12:05
@ajaypnair09 ajaypnair09 force-pushed the Add-asciidoctor-reducer branch from 55b2112 to 78f1dab Compare October 15, 2024 12:08
@ajaypnair09 ajaypnair09 force-pushed the Add-asciidoctor-reducer branch from 78f1dab to 731a5da Compare October 15, 2024 12:16
@ajaypnair09
Copy link
Contributor Author

ajaypnair09 commented Oct 16, 2024

@conda-forge/help-ruby please review and merge if it is fine

@ajaypnair09
Copy link
Contributor Author

ajaypnair09 commented Oct 29, 2024

@conda-forge/help-ruby , Gentle reminder. Kindly review and merge the pull request

@ajaypnair09
Copy link
Contributor Author

ajaypnair09 commented Nov 11, 2024

@conda-forge/staged-recipes , @conda-forge/help-ruby , Kindly review and merge the pull request

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@ajaypnair09
Copy link
Contributor Author

ajaypnair09 commented Nov 25, 2024

Hello @wolfv , There are some changes from the version you have reviewed. Kindly review the changes again.

@abloemert
Copy link
Member

abloemert commented Dec 16, 2024

@conda-forge/staged-recipes can this PR be merged?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@abloemert
Copy link
Member

abloemert commented Dec 21, 2024

@conda-forge/help-ruby @wolfv can you take a look at this PR?

@jdmarques jdmarques mentioned this pull request Jan 6, 2025
Merged
10 tasks
jdmarques
jdmarques reviewed Jan 6, 2025
View reviewed changes
recipes/asciidoctor-reducer/meta.yaml
- gem install -N -l -V --norc --ignore-dependencies -n $PREFIX/bin {{ name }}-{{ version }}.gem
- gem unpack {{ name }}-{{ version }}.gem
- cp -v asciidoctor-reducer.bat $PREFIX/bin/asciidoctor-reducer.bat
skip: {{ win }}
Copy link
Contributor

@jdmarques jdmarques Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajaypnair09 why is this skipping windows?

Copy link
Member

@abloemert abloemert Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to fix the entry-point. When building on Linux, it will create the right executable file for unix-system. By adding the .bat script it will create a noarch package.

recipes/asciidoctor-reducer/conda_build_config.yaml
ruby:
- 3.1
- 3.2
- 3.3
Copy link
Contributor

@jdmarques jdmarques Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prob better to add - 3.4as it is already available

Copy link
Contributor

@jdmarques jdmarques Jan 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to remove -3.1, version 3.1 is close to EOL and has some issues, I faced the same issue while adding some other ruby packages.
7368c07

Copy link
Contributor Author

@ajaypnair09 ajaypnair09 Jan 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruby 3.4 can be added after conda-forge/asciidoctor-feedstock#17 => done

@ajaypnair09 ajaypnair09 force-pushed the Add-asciidoctor-reducer branch from 4eb110f to 72de58e Compare January 8, 2025 06:30
@ajaypnair09 ajaypnair09 force-pushed the Add-asciidoctor-reducer branch from 53b4bcc to d741ea6 Compare January 8, 2025 09:32
@abloemert
Copy link
Member

abloemert commented Jan 12, 2025 •
edited
Loading

@chrisburr, @xhochy, can you maybe check if this PR can be merged?

@abloemert
Copy link
Member

abloemert commented Feb 10, 2025

@ocefpaf can you maybe help here?

ocefpaf
ocefpaf reviewed Feb 11, 2025
View reviewed changes
recipes/asciidoctor-reducer/meta.yaml Outdated
- asciidoctor-reducer -h

about:
home: https://rubygems.org/gems/{{ name }}
Copy link
Member

@ocefpaf ocefpaf Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the excess of jinja? It makes the URLs unusable and serves no purpose, we recommend it just for the version and the name in rare places, like PyPI URLs. Also not that the future recipe format will remove jinja, so you are already future proofing it.

@ocefpaf ocefpaf merged commit 37a62ed into conda-forge:main Feb 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocefpaf ocefpaf ocefpaf left review comments

@wolfv wolfv Awaiting requested review from wolfv

+2 more reviewers

@jdmarques jdmarques jdmarques left review comments

@abloemert abloemert abloemert left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

R review-requested ruby staged-recipes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ajaypnair09 @conda-forge-admin @abloemert @wolfv @ocefpaf @jdmarques