-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MadGraph5_aMC@NLO #29054
Add MadGraph5_aMC@NLO #29054
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notes for reviewers as making mg5amcnlo
portable/installable is weird and rather hacky.
# Build configuration file be replacing placeholder values with PREFIX | ||
- cp $RECIPE_DIR/mg5_configuration.txt . | ||
- sed -i "s|REPLACE_WITH_PREFIX|$PREFIX|g" mg5_configuration.txt | ||
- sed -i "s|REPLACE_WITH_BASENAME_FC|$(basename $FC)|g" mg5_configuration.txt | ||
- sed -i "s|REPLACE_WITH_BASENAME_GXX|$(basename $GXX)|g" mg5_configuration.txt | ||
- mv mg5_configuration.txt $PREFIX/MG5_aMC/input/mg5_configuration.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mg5amcnlo
looks up all the tools it knows about and can use for code generation using MG5_aMC/input/mg5_configuration.txt
. The author assumed you would always compile everything from scratch on every machine you ever used it on. To avoid this and get the correct paths for the conda-forge packages installed as run
requirements, use REPLACE_WITH_
variables in mg5_configuration.txt
to overwrite with the value of their $PREFIX
paths so they will be found correctly at install time.
Instead of trying to properly sed -i
edit each line of mg5_configuration.txt
during the build, include mg5_configuration.txt
as a file in the feedstock source to then overwrite and mv
into what is packaged.
# modified University of Illinois/NCSA license | ||
license: LicenseRef-NCSA | ||
license_family: OTHER | ||
license_file: source/LICENSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c857545
to
7140d8e
Compare
|
||
build: | ||
# FIXME: mg5amcnlo doesn't support Python 3.12 yet | ||
skip: true # [py<37 or py>311 or win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment this could technically be noarch
, but as the goal is to add compiled components to support Pythia8 in the future, it would have to move away from noarch
, so might as well start off as non-noarch
.
1a3f005
to
82f06c9
Compare
* Add MadGraph5_aMC@NLO v3.5.7. - c.f. https://github.com/mg5amcnlo/mg5amcnlo - Add tutorial example (tutorial.mg5) for a simple test. * Integration with Pythia8 via MG5aMC_PY8_interface is not yet supported. - c.f. https://github.com/mg5amcnlo/MG5aMC_PY8_interface * Detection of existing libraries (ninja, collier) for NLO calculations is not supported yet either given bugs.
82f06c9
to
57e0e87
Compare
@conda-forge/staged-recipes, ready for review! This is partly a python package, but it is a bit of an odd collection. cc @chrisburr given the particle physics context here. |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
MadGraph5_aMC@NLO v3.5.7
.tutorial.mg5
) for a simple test.MG5aMC_PY8_interface
is not yet supported.ninja
,collier
) for NLO calculations is not supported yet either given bugs.Checklist
.tar.gz
from the official source or the archive).MadGraph5_aMC@NLO
vendors multiple pieces of software, written by the same author. (c.f. Requirements for packaging on conda-forge mg5amcnlo/mg5amcnlo#156). To combat this, as much as possible has been added to conda-forge as packages (c.f. Package mg5amcnlo dependencies hep-packaging-coordination/packaging-hep-simulation-stack#3) though the last bits that exist under the$PREFIX/MG5_aMC/vendor
are currently not used and the goal is to eventually work to get these properly moved out. The code under$PREFIX/MG5_aMC/vendor
is not accessed until NLO calculations are performed at which time is it compiled. So it is possible to usemg5amcnlo
without triggering this ever (though this limits you to leading order).url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).