Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pyudunits2 #29055

Merged
merged 4 commits into from
Feb 11, 2025
Merged

add pyudunits2 #29055

merged 4 commits into from
Feb 11, 2025

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Feb 7, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.


extra:
recipe-maintainers:
- pelson
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pelson is it OK to add you here?

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/pyudunits2/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: pelson. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pyudunits2/meta.yaml) and found some lint.

Here's what I've got...

For recipes/pyudunits2/meta.yaml:

  • ❌ The home item is expected in the about section.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13197300220. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyudunits2/meta.yaml) and found it was in an excellent condition.

@@ -45,4 +45,3 @@ about:
extra:
recipe-maintainers:
- pelson
- ocefpaf
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phil we can re-add you anytime, removing now just to get this one merged. (We require OKs from maintainers now.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you might have removed the wrong name based on your above comment 😉

@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 11, 2025

@conda-forge/staged-recipes this one is ready for review!

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@synapticarbors
Copy link
Member

@ocefpaf -- LGTM. If I forget to circle back around once the CI passes (assuming it does without issues), feel free to merge this.

@ocefpaf ocefpaf merged commit ebb3a5e into conda-forge:main Feb 11, 2025
6 of 7 checks passed
@ocefpaf ocefpaf deleted the pyudunits2 branch February 11, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants