Add cerberecontrib-ghrsst recipe #29189

cso2943 · 2025-02-17T15:48:09Z

Checklist

github-actions · 2025-02-17T15:49:28Z

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

recipes/cerberecontrib_ghrsst/meta.yaml:
- lints:
  - The following maintainers have not yet confirmed that they are willing to be listed here: marie59. Please ask them to comment on this PR if they are.

conda-forge-admin · 2025-02-17T15:50:05Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cerberecontrib_ghrsst/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/cerberecontrib_ghrsst/meta.yaml:

ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
- For the host section of recipe, you should usually use python {{ python_min }} for the python entry.
- For the run section of recipe, you should usually use python >={{ python_min }} for the python entry.
- For the test.requires section of recipe, you should usually use python {{ python_min }} for the python entry.
- If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13393931224. Examine the logs at this URL for more detail.}

Marie59 · 2025-02-17T16:01:14Z

Hi ! I will look tomorrow if you need help on the checks ;)

criou-cg · 2025-02-17T16:02:35Z

ok

erwanbodere · 2025-02-17T16:24:12Z

ok

jfpiolle · 2025-02-17T17:24:00Z

ok

Marie59 · 2025-02-18T08:34:48Z

recipes/cerberecontrib_ghrsst/meta.yaml

+    - python >=3.10.0,<3.11
+    - cerbere >=3.1.2
+
+test:


So your test is failing.
cerberecontrib-ghrsst 0.0.0.post146767+30809b91c0 has requirement cerbere<4.0.0,>=3.1.2, but you have cerbere 0.0.0.post21+c94c7d1.
So I'd say maybe from this we need to add in the test the import of cerbere

recipes/cerberecontrib_ghrsst/meta.yaml

Co-authored-by: Marie Jossé <[email protected]>

recipes/cerberecontrib_ghrsst/meta.yaml

Co-authored-by: Marie Jossé <[email protected]>

github-actions · 2025-02-18T08:50:10Z

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

Marie59 · 2025-02-18T08:55:33Z

recipes/cerberecontrib_ghrsst/meta.yaml

+    - pip
+  run:
+    - python >=3.10.0,<3.11
+    - cerbere >=3.1.2


Suggested change

- cerbere >=3.1.2

- cerbere >=3.1.2,4.0.0

Marie59 · 2025-02-18T08:55:57Z

recipes/cerberecontrib_ghrsst/meta.yaml

+  imports:
+    - cerberecontrib_ghrsst
+  requires:
+    - cerbere


Suggested change

- cerbere

- cerbere >=3.1.2,4.0.0

Okay let's put the version more strictly see if it's better

Marie59 · 2025-02-18T12:19:28Z

Hi @conda-forge/help-python and @conda-forge/staged-recipes
We have one last error here and the message is a bit cryptic for us...
Do you have any suggestions ?
Thanks for the review !!

github-actions · 2025-02-18T12:19:38Z

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

recipes/cerberecontrib_ghrsst/meta.yaml

github-actions · 2025-02-18T15:32:42Z

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

recipes/more_itertools/meta.yaml:
- lints:
  - Feedstock with the same name exists in conda-forge.
- hints:
  - A conda package with same name (more-itertools) already exists.

conda-forge-admin · 2025-02-18T15:33:03Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/more_itertools/meta.yaml, recipes/cerberecontrib_ghrsst/meta.yaml) and found some lint.

Here's what I've got...

For recipes/more_itertools/meta.yaml:

❌ The recipe must have some tests.
❌ Non noarch packages should have python requirement without any version constraints.
❌ Non noarch packages should have python requirement without any version constraints.

For recipes/more_itertools/meta.yaml:

ℹ️ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

For recipes/cerberecontrib_ghrsst/meta.yaml:

ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
- For the host section of recipe, you should usually use python {{ python_min }} for the python entry.
- For the run section of recipe, you should usually use python >={{ python_min }} for the python entry.
- For the test.requires section of recipe, you should usually use python {{ python_min }} for the python entry.
- If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13394217709. Examine the logs at this URL for more detail.}

github-actions · 2025-02-18T15:38:26Z

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

conda-forge-admin · 2025-02-18T15:38:48Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cerberecontrib_ghrsst/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/cerberecontrib_ghrsst/meta.yaml:

ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
- For the run section of recipe, you should usually use python >={{ python_min }} for the python entry.
- If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13453437725. Examine the logs at this URL for more detail.}

Marie59 · 2025-02-18T15:40:33Z

@criou-cg I think it would be best to open one PR for each package

Marie59 · 2025-02-18T15:41:54Z

I propose you remove the more-itertools from here and open a new one on other branch of your fork of staged-recipes

Co-authored-by: Filipe <[email protected]>

cso2943 · 2025-02-18T16:11:15Z

@conda-forge/help-python my recipe is ready !

ocefpaf · 2025-02-18T16:24:59Z

recipes/cerberecontrib_ghrsst/meta.yaml

+    - poetry-dynamic-versioning >=1.0.0,<2.0.0
+    - pip
+  run:
+    - python {{ python_min }}


Is this py310 only? If not you need the >=.

Suggested change

- python {{ python_min }}

- python >={{ python_min }}

Yes it is py310 only.

cso2943 · 2025-02-19T16:33:53Z

@conda-forge/help-python @conda-forge/staged-recipes my recipe is ready !

Co-authored-by: Filipe <[email protected]>

ocefpaf · 2025-02-21T09:10:12Z

recipes/cerberecontrib_ghrsst/meta.yaml

+    - pip
+  run:
+    - python {{ python_min }}
+    - cerbere >=3.1.2,<4.0.0


The metadata in this package should be fixed and pip-check added there as well to avoid regressions.

+ pip check cerberecontrib-ghrsst 3.1.2 has requirement cerbere<4.0.0,>=3.1.2, but you have cerbere 0.0.0.post21+c94c7d1.

@ocefpaf Is this an issue coming from the metadata within the pyproject.toml ? or somewhere else ?

Thanks a lot for the help and review !!

It depends on how the package creates the version info. Sadly the Python packaging ecosystem has way too many ways to do this. Depending on what you use we can "fake" a version and fix it later upstream, I'll check cerbere in a moment.

See https://github.com/conda-forge/cerbere-feedstock/pull/3/files#r1965168737. Once that one is merged and the new cerbere is available in the, we can restart the CIs here.

conda-forge-admin · 2025-02-21T10:10:06Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cerberecontrib_ghrsst/meta.yaml) and found some lint.

Here's what I've got...

For recipes/cerberecontrib_ghrsst/meta.yaml:

❌ There are 1 too many lines. There should be one empty line at the end of the file.

For recipes/cerberecontrib_ghrsst/meta.yaml:

ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
- For the run section of recipe, you should usually use python >={{ python_min }} for the python entry.
- If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13454559391. Examine the logs at this URL for more detail.}

conda-forge-admin · 2025-02-21T10:35:28Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cerberecontrib_ghrsst/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/cerberecontrib_ghrsst/meta.yaml:

ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
- For the run section of recipe, you should usually use python >={{ python_min }} for the python entry.
- If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13454985366. Examine the logs at this URL for more detail.}

cso2943 · 2025-02-21T10:49:34Z

@conda-forge/help-python @conda-forge/staged-recipes my recipe is ready !

github-actions · 2025-02-21T10:49:46Z

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

Marie59 · 2025-02-21T13:34:45Z

Thanks a lot @ocefpaf !!

cso2943 · 2025-02-21T13:36:16Z

Thanks for your help @ocefpaf !

Add cerberecontrib-ghrsst recipe

a2ae8d6

cso2943 added 2 commits February 17, 2025 17:04

Fix sha256

6571cdc

Fix tests imports

5548f39

cso2943 added 2 commits February 17, 2025 18:02

Add cerberecontrib_ghrsst recipe

f83dd26

Delete recipes/cerberecontrib-ghrsst directory

6ca1504

Marie59 reviewed Feb 18, 2025

View reviewed changes

recipes/cerberecontrib_ghrsst/meta.yaml Outdated Show resolved Hide resolved

Addition of cerbere to tests requirements

3206b1b

Co-authored-by: Marie Jossé <[email protected]>

Marie59 reviewed Feb 18, 2025

View reviewed changes

recipes/cerberecontrib_ghrsst/meta.yaml Outdated Show resolved Hide resolved

Fix Marie59 maintainer's pseudo

d23f70a

Co-authored-by: Marie Jossé <[email protected]>

Marie59 reviewed Feb 18, 2025

View reviewed changes

cso2943 added 3 commits February 18, 2025 10:10

Fix cerbere version

0185d3c

Fix tests

ce71bcb

Update meta.yaml

ed5fc97

github-actions bot added review-requested staged-recipes python labels Feb 18, 2025

Merge branch 'main' into main

48f040d

ocefpaf reviewed Feb 18, 2025

View reviewed changes

recipes/cerberecontrib_ghrsst/meta.yaml Outdated Show resolved Hide resolved

recipes/cerberecontrib_ghrsst/meta.yaml Outdated Show resolved Hide resolved

recipes/cerberecontrib_ghrsst/meta.yaml Show resolved Hide resolved

ocefpaf reviewed Feb 18, 2025

View reviewed changes

recipes/cerberecontrib_ghrsst/meta.yaml Outdated Show resolved Hide resolved

Add more_itertools recipe

045840d

Delete recipes/more_itertools directory

82c4ce0

cso2943 and others added 4 commits February 18, 2025 16:49

Update recipes/cerberecontrib_ghrsst/meta.yaml

38a9beb

Co-authored-by: Filipe <[email protected]>

Update recipes/cerberecontrib_ghrsst/meta.yaml

710f12e

Co-authored-by: Filipe <[email protected]>

Update recipes/cerberecontrib_ghrsst/meta.yaml

e4c678e

Co-authored-by: Filipe <[email protected]>

Update meta.yaml

fe32828

ocefpaf reviewed Feb 18, 2025

View reviewed changes

Addition of pip-check test

72032db

Co-authored-by: Filipe <[email protected]>

ocefpaf reviewed Feb 21, 2025

View reviewed changes

Restart CI after cerbere dependency rebuild

78d40fc

Remove extra empty line at the end of file

9ebf649

ocefpaf merged commit 8ec48f6 into conda-forge:main Feb 21, 2025
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add cerberecontrib-ghrsst recipe #29189

Add cerberecontrib-ghrsst recipe #29189

cso2943 commented Feb 17, 2025

github-actions bot commented Feb 17, 2025 •

edited

Loading

conda-forge-admin commented Feb 17, 2025 •

edited

Loading

Marie59 commented Feb 17, 2025

criou-cg commented Feb 17, 2025

erwanbodere commented Feb 17, 2025

jfpiolle commented Feb 17, 2025

Marie59 Feb 18, 2025

github-actions bot commented Feb 18, 2025

Marie59 Feb 18, 2025

Marie59 Feb 18, 2025

Marie59 Feb 18, 2025

Marie59 commented Feb 18, 2025

github-actions bot commented Feb 18, 2025

github-actions bot commented Feb 18, 2025

conda-forge-admin commented Feb 18, 2025

github-actions bot commented Feb 18, 2025

conda-forge-admin commented Feb 18, 2025 •

edited

Loading

Marie59 commented Feb 18, 2025 •

edited

Loading

Marie59 commented Feb 18, 2025

cso2943 commented Feb 18, 2025

ocefpaf Feb 18, 2025

cso2943 Feb 18, 2025

cso2943 commented Feb 19, 2025 •

edited

Loading

ocefpaf Feb 21, 2025

Marie59 Feb 21, 2025 •

edited

Loading

ocefpaf Feb 21, 2025

ocefpaf Feb 21, 2025

conda-forge-admin commented Feb 21, 2025

conda-forge-admin commented Feb 21, 2025

cso2943 commented Feb 21, 2025

github-actions bot commented Feb 21, 2025

Marie59 commented Feb 21, 2025

cso2943 commented Feb 21, 2025

Add cerberecontrib-ghrsst recipe #29189

Add cerberecontrib-ghrsst recipe #29189

Conversation

cso2943 commented Feb 17, 2025

github-actions bot commented Feb 17, 2025 • edited Loading

conda-forge-admin commented Feb 17, 2025 • edited Loading

Marie59 commented Feb 17, 2025

criou-cg commented Feb 17, 2025

erwanbodere commented Feb 17, 2025

jfpiolle commented Feb 17, 2025

Choose a reason for hiding this comment

github-actions bot commented Feb 18, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Marie59 commented Feb 18, 2025

github-actions bot commented Feb 18, 2025

github-actions bot commented Feb 18, 2025

conda-forge-admin commented Feb 18, 2025

github-actions bot commented Feb 18, 2025

conda-forge-admin commented Feb 18, 2025 • edited Loading

Marie59 commented Feb 18, 2025 • edited Loading

Marie59 commented Feb 18, 2025

cso2943 commented Feb 18, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cso2943 commented Feb 19, 2025 • edited Loading

Choose a reason for hiding this comment

Marie59 Feb 21, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conda-forge-admin commented Feb 21, 2025

conda-forge-admin commented Feb 21, 2025

cso2943 commented Feb 21, 2025

github-actions bot commented Feb 21, 2025

Marie59 commented Feb 21, 2025

cso2943 commented Feb 21, 2025

github-actions bot commented Feb 17, 2025 •

edited

Loading

conda-forge-admin commented Feb 17, 2025 •

edited

Loading

conda-forge-admin commented Feb 18, 2025 •

edited

Loading

Marie59 commented Feb 18, 2025 •

edited

Loading

cso2943 commented Feb 19, 2025 •

edited

Loading

Marie59 Feb 21, 2025 •

edited

Loading