Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metplus #29208

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add metplus #29208

wants to merge 13 commits into from

Conversation

georgemccabe
Copy link

@georgemccabe georgemccabe commented Feb 19, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/metplus/meta.yaml) and found some lint.

Here's what I've got...

For recipes/metplus/meta.yaml:

  • ❌ The top level meta key channels is unexpected
  • ❌ Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [44, 86, 106, 133]
  • ❌ The recipe must have a build/number section.
  • requirements: build: gcc_linux-64=12 must contain a space between the name and the pin, i.e. gcc_linux-64 =12
  • requirements: build: netcdf-cxx4=4.3.1 must contain a space between the name and the pin, i.e. netcdf-cxx4 =4.3.1
  • requirements: build: libopenblas==0.3.28 must contain a space between the name and the pin, i.e. libopenblas ==0.3.28
  • requirements: build: _openmp_mutex=4.5 must contain a space between the name and the pin, i.e. _openmp_mutex =4.5
  • ❌ This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

For recipes/metplus/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13423773922. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 19, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/metplus/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/metplus/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13464627850. Examine the logs at this URL for more detail.

@georgemccabe
Copy link
Author

I confirm that I am willing to be a maintainer of this recipe

@georgemccabe
Copy link
Author

Note: Recipe must use Python 3.10 because the MET C++ code needs to be compiled with the same version of Python that will be installed.

@georgemccabe georgemccabe marked this pull request as ready for review February 21, 2025 23:04
@georgemccabe
Copy link
Author

@conda-forge/staged-recipes, ready for review.
@conda-forge/help-c-cpp, @conda-forge/help-python, @conda-forge/help-python-c

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants