-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Add instruction to make a new branch from 'main' #29226
DOC: Add instruction to make a new branch from 'main' #29226
Conversation
* Multiple people forget to do this when trying to add recipes and then run into trouble, so add an explicit instruction to create a new branch.
@conda-forge/staged-recipes, ready for review! |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good recommendation. However, I'll defer to others for merging.
Also, worth noting that this simply brings the README here into harmony with the documentation: https://conda-forge.org/docs/maintainer/adding_pkgs/#step-by-step-instructions
That alone is worth it. (Some) people realistically aren't reading the maintainer docs before coming here, but if that's the goal then it should be made much more prominent than a link in step 2 of high level instructions in the README Line 18 in 8a71ace
|
The linter is probably stuck b/c it is looking for a recipe. Merging this... Thanks! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).