Skip to content

Conversation

@davidbrochart
Copy link
Member

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@davidbrochart davidbrochart marked this pull request as draft November 29, 2025 16:13
@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 29, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ghostty/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/ghostty/recipe.yaml:

  • ❌ The recipe must have some tests.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19786957190. Examine the logs at this URL for more detail.

@davidbrochart
Copy link
Member Author

The build fails with:

zig build -p $PREFIX -Doptimize=ReleaseFast
thread 385 panic: pkg-config failed for library gio-2.0

I can reproduce locally, but I can see that I have:

/home/david/.local/share/mamba/envs/tmp-ghostty/lib/libgio-2.0.so.0
/home/david/.local/share/mamba/envs/tmp-ghostty/lib/pkgconfig/gio-2.0.pc
/home/david/.local/share/mamba/envs/tmp-ghostty/lib/pkgconfig/gio-unix-2.0.pc
/home/david/.local/share/mamba/envs/tmp-ghostty/lib/libgio-2.0.so
/home/david/.local/share/mamba/envs/tmp-ghostty/lib/libgio-2.0.so.0.8600.2

Any idea @conda-forge/staged-recipes @conda-forge/help-c-cpp?

@github-actions
Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@davidbrochart
Copy link
Member Author

I got past the error reported here. I'm now packaging libadwaita in #31585.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants