Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update check-cla action #204

Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open

Update check-cla action #204

wants to merge 53 commits into from

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Aug 16, 2024 •
edited
Loading

Description

A few maintenance improvements:

  • converts metadata step (previously JS code) into GitHub Action Expressions
  • converts add signee step (previously JS code) into Python script
  • updates default input values based on upcoming move from conda/infrastructure to conda/cla

Depends on #203

Questions

  • Do we really need to be setting a cla-signed [bot] added once the contributor has signed the CLA label? It's the CLA check status that's actually being used to verify if a contributor has signed the CLA so is the cla-signed [bot] added once the contributor has signed the CLA label just noise?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 16, 2024
@kenodegard kenodegard changed the title Update check-cla Update check-cla action Aug 16, 2024
jezdez
jezdez reviewed Aug 20, 2024
View reviewed changes
jezdez
jezdez reviewed Aug 20, 2024
View reviewed changes
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@kenodegard
Use user id instead of login to avoid invalid chars
6264ecd 
Sometimes the login is a bot account that has the `[bot]` suffix. The brackets causes issues for branch names so using the raw user ID (and integer) is better.
@kenodegard kenodegard marked this pull request as ready for review January 10, 2025 15:56
@kenodegard kenodegard requested a review from a team as a code owner January 10, 2025 15:56
@conda-bot
Copy link
Contributor

conda-bot commented Jan 21, 2025 •
edited
Loading

Warning

This is a test of the CLA system. Review for correctness but otherwise ignore this comment.

We require contributors to sign our Contributor License Agreement and we don't have one on file for @login (204).

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda-sandbox/cla#7), and ping the bot to refresh the PR.

Commands

Trigger actions by commenting on this PR:

  • @conda-bot check will check whether a CLA has been signed for this PR author

@conda-bot conda-bot mentioned this pull request Jan 22, 2025
Open
@kenodegard kenodegard force-pushed the check-cla branch 2 times, most recently from 067bdea to 8df586d Compare January 22, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jezdez jezdez jezdez left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
🔎 Review
Status: 👀 In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenodegard @conda-bot @jezdez