Skip to content

Warn about future macOS name change #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Warn about future macOS name change #859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions constructor/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import logging
import os
import sys
import warnings
from os.path import abspath, expanduser, isdir, join
from textwrap import dedent, indent

Expand Down Expand Up @@ -58,6 +59,13 @@ def get_output_filename(info):

osname, arch = info['_platform'].split('-')
os_map = {'linux': 'Linux', 'osx': 'MacOSX', 'win': 'Windows'}
if osname == "osx":
warnings.warn(
"constructor 3.11.* will use the 'macOS' label (instead of 'MacOSX') for "
"the osx-* platforms. This will change the default name of the generated installers. "
"Use 'installer_filename' to control this default behavior.",
FutureWarning,
)
arch_name_map = {'64': 'x86_64', '32': 'x86'}
ext = info['installer_type']
return '%s-%s-%s.%s' % ('%(name)s-%(version)s' % info,
Expand Down