Conversation
mkulke
force-pushed
the
mkulke/add-support-for-ubuntu-podmvm-on-azure
branch
2 times, most recently
from
August 9, 2026 17:37
6ae3c2d to
c23cf59
Compare
mkulke
marked this pull request as ready for review
August 9, 2026 22:20
bpradipt
reviewed
Aug 10, 2026
bpradipt
approved these changes
Aug 10, 2026
mkulke
force-pushed
the
mkulke/add-support-for-ubuntu-podmvm-on-azure
branch
2 times, most recently
from
August 12, 2026 04:27
3206354 to
ac1f66c
Compare
Collaborator
Author
there are runs on my fork, using a different trigger, though. the full-machinery is tricky to test, so it might require follow-up fixes: https://github.com/mkulke/cloud-api-adaptor/actions/runs/30973384611 |
mkulke
force-pushed
the
mkulke/add-support-for-ubuntu-podmvm-on-azure
branch
2 times, most recently
from
August 17, 2026 13:59
9a4b1de to
3fcacff
Compare
Since we don't use the "default" meta-package, we have to add the modules explicitly. Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
Ubuntu doesn't have the afterburn utility that is being used on fedora to report an VM as ready. Building the afterburn tool requires a rust buildchain. The call-home functionality is pretty trivial, so we can add a small "azure-ready" cli that is scoped to this task. We invoke it as a one-off systemd unit behind a condition check that will only run this unit on Azure. Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
The Makefile provides a couple of targets that help with image creation and publishing for azure. Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
We need this because PodVM do not get automatic internet access (anymore). Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
To avoid resource leakage during e2e test runs we implement the delete VM function and make sure that it is executed in the right order and propagate the error to the caller. Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
The workflow is modelled after similar workflows for libvirt and AWS. Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
Instead of running a costly gh action matrix, we specify the instance-size in the tests, so they can run on the same AKS cluster. Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
Inlined the test into the azure test file, since it wasn't used elsewhere, also made it use both SNP and TDX. Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
The current matching logic was flawed because it ignored the random strings. It was only exercised by a skipped test, so it went unnoticed, but we'll need it eventually. Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
This change will run azure e2e test in the daily schedule or when triggered manually. Note: the e2e tests cannot be triggered by a label on a PR for security reasons, since the test suite requires privileges on an azure subscription. Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
mkulke
force-pushed
the
mkulke/add-support-for-ubuntu-podmvm-on-azure
branch
from
August 17, 2026 14:00
3fcacff to
1eaee8f
Compare
Member
Understood. We are not close to a release, so I think it's fine to merge and give it a try |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The switch to ubuntu images required some changes to support azure. The individual commits describe the changes in more detail, but the gist is: