aa: make lint cover all workspace packages under attestation-agent

[Xynnn007]

Previously make lint only clippy'd the attestation-agent crate, so sibling crates (notably attester's evidence_getter via bin) were never linted. Clippy each package with -D warnings, and use --all-targets plus bin where binaries exist.

Note that sev parts are also included as they are in tree. I will make a separate PR to get rid of them altogether.

[fitzthum]

Is there a good way to just check all the packages? Maybe cargo clippy --all? This seems a little fragile as-is.

[mythi]

Clippy each package with -D warnings, and use --all-targets plus bin where binaries exist.

I wonder if cargo clippy --workspace --all-targets -- -D warnings would be sufficient?

[Xynnn007]

The Makefile now is under attestation-agent directory, thus as blackbox it's proper for it to only cover crates under the attestation-agent/*.

There are two ways to fix original issue

1. get this merged and improve clippy coverage ASAP and let's refactor the messy CI code in the repo
2. refactor the messy CI code in the repo, including Makefiles

I prefer 1, to resolve things asap and let's do "make it better" work then.

[mythi]

my 2 cents is that the coverage gap is not critical enough that it cannot wait proper refactoring.

[fitzthum]

I guess I am fine with this in the short term. From the CI perspective, we don't really need to lint the components individually. It shouldn't take too much of a refactor to just lint the entire workspace instead. I guess we might want to keep this Make target around tho.