-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create td-shim-interface crate for publishig #657
Conversation
@NK-fengsf, @studychao, would you please take a look? |
@OuyangHang33 , would you mind move TdShimLoader from td_shim_tools crate to td-shim-interface crate? |
@NK-fengsf I'll check the feasibility today, and will let you know if move the td-shim-loader crate. |
Hi @NK-fengsf , Could you give the reason why you need TdShimLoader, and how do you want to use it. |
Dragonball VMM parse tdshim image and get Vec using TdShimLoader::parse(filename:&String)。 I can make a copy of loader.rs into Dragonball sandbox , if it is not suitable to move loader.rs from |
If my understanding is correct, you just need to have a parse() function. The reason is that we are NOT able to handle file operation in non-std env. |
yes, I just need the parse function. It's okay for me to change the API to accept a binary string and output the metadata descriptor. |
Hi @jyao1 @NK-fengsf , I create the PR to change the API and split the read_file operation: #660. |
Signed-off-by: OuyangHang33 <[email protected]>
Hi @OuyangHang33 , I have no other needs apart from this. Thank you very much. |
Hi @NK-fengsf , I have moved TdShimLoader from td_shim_tools crate to td-shim-interface crate. |
Signed-off-by: OuyangHang33 <[email protected]>
Hi @NK-fengsf , could you test the new crate? if it can meet your requirement, we will publish it after merged. |
@OuyangHang33 Okay, I will finish the test before tomorrow evening。 |
I have tested the td-shim-interface crate, it works well in dragonball-sandbox. @OuyangHang33 , CC @jyao1 |
Fix: #654