Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split tdx feature originated from tdx-tdcall into two features: tdcall and tdvmcall as tdvmcall usage may be optional for some use cases #767

Closed
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
6d6116c
tdx-tdcall: Add a feature and separate tdvmcall to a dedicated file
sgrams Mar 3, 2025
c85adc3
tdx-tdcall: Split tdx.rs into tdcall.rs and tdvmcall.rs
sgrams Mar 3, 2025
3f7069d
tdx-tdcall: move remaining tdcall functions into tdcall.rs
sgrams Mar 3, 2025
614c4ad
tdx-tdcall: remove tdvmcall_ prefix
sgrams Mar 3, 2025
6cb7de4
tdx-tdcall: remove tdcall_ prefix
sgrams Mar 3, 2025
5bf8e83
Replace tdvmcall_ with tdvmcall::
sgrams Mar 3, 2025
ebc17ee
Replace tdcall_ with tdcall::
sgrams Mar 3, 2025
383f9fa
tdx-tdcall: Revert rename in CHANGELOG.md
sgrams Mar 5, 2025
4afbf1f
tdx-tdcall: add tdcall feature and add default features
sgrams Mar 3, 2025
1746f9b
td-payload: adapt to new tdx-tdcall layout
sgrams Mar 3, 2025
bc5bf16
td-logger: adapt to new tdx-tdcall layout
sgrams Mar 3, 2025
8485407
td-exception: adapt to new tdx-tdcall layout
sgrams Mar 3, 2025
93e3ca4
td-shim: adapt to new tdx-tdcall layout
sgrams Mar 3, 2025
fe36056
tests: adapt to new tdx-tdcall layout
sgrams Mar 3, 2025
6961b90
xtask: adapt to new tdx-tdcall layout
sgrams Mar 4, 2025
013c6c0
tdx-tdcall: move td-report under tdcall feature
sgrams Mar 4, 2025
eb829c5
td-payload: add non-tdvmcall version of enable_apic_interrupt
sgrams Mar 4, 2025
50056a3
td-payload: add non-tdvmcall versions of decrypt and encrypt
sgrams Mar 4, 2025
97db275
tdx-tdcall: Bump version after changing the API
sgrams Mar 3, 2025
0a39437
Cargo.lock: lock tdx-tdcall version after bump
sgrams Mar 4, 2025
e8faa4c
xtask: enable tdvmcall feature by default
sgrams Mar 5, 2025
9ccd236
tdx-tdcall: fix-up src/asm after tdcall rename
sgrams Mar 5, 2025
b4c44a3
.github: update CI to use tdcall and tdvmcall instead of tdx feature
sgrams Mar 5, 2025
5212396
tdx-tdcall: fix-up clippy errors
sgrams Mar 5, 2025
ddc36b7
tdx-tdcall,td-payload: fix-up cargo fmt errors
sgrams Mar 5, 2025
a7c03cb
sh_script: replace tdx feature with tdcall and tdvmcall
sgrams Mar 5, 2025
4b445f0
tdx-tdcall: Update CHANGELOG.md
sgrams Mar 5, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
xtask: enable tdvmcall feature by default
Signed-off-by: Stanislaw Grams <[email protected]>
sgrams committed Mar 7, 2025
commit e8faa4cc6cc603f26ea5f6238636da26227e9e5e
6 changes: 3 additions & 3 deletions xtask/src/build.rs
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ use std::{
};
use xshell::{cmd, Shell};

const TD_SHIM_DEFAULT_FEATURES: &str = "main,tdcall";
const TD_SHIM_DEFAULT_FEATURES: &str = "main,tdcall,tdvmcall";

lazy_static! {
static ref PROJECT_ROOT: &'static Path =
@@ -42,7 +42,7 @@ pub(crate) struct BuildArgs {
#[arg(short, long)]
output: Option<PathBuf>,
/// List of features of `td-shim` crate to activate in addition to the `main` and `tdcall`,
/// separated by comma. By default, only the `main` and `tdcall` features of `td-shim` are enabled
/// separated by comma. By default, only the `main`, `tdcall` and `tdvmcall` features of `td-shim` are enabled
#[arg(long)]
features: Option<String>,
/// Path of customized metadata configuration file
@@ -140,7 +140,7 @@ impl BuildArgs {
sh,
"cargo build -p td-payload --bin example --target x86_64-unknown-none"
)
.args(["--features", "tdcall,start,cet-shstk,stack-guard"])
.args(["--features", "tdcall,tdvmcall,start,cet-shstk,stack-guard"])
.args(["--profile", self.profile()])
.run()?;