-
Notifications
You must be signed in to change notification settings - Fork 935
Fix 'propogation' a typo - 'propagation' #2062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* Update topic prefix to include partition.assignment.strategy * Add test to check uniqueness after each rebalance * Add test to check all partitions are assigned after each rebalance * Extracted variable for repetitive code part
🎉 All Contributor License Agreements have been signed. Ready to merge. |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
bf64b91
to
e81f784
Compare
The base branch was changed.
number_of_partitions = 10 | ||
|
||
|
||
def get_group_protocol_type(a, group_id): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are those changes (adding test) also intended for this PR (fixing typo)?
return name | ||
|
||
def create_topic_and_wait_propogation(self, prefix, conf=None, **create_topic_kwargs): | ||
def delete_topic(self, topic): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same - it this intended to be added
A typo fix. From 'propogation' to 'propagation'